[#44301] - [6.0] Apply strict string comparisons
- Closed
- 16 Aug 2025
- Medium
- Build: 5.3-dev
- # 44301
- Diff
- Denitz:patch53/safe-strict-string-comparison
User tests: Successful: Unsuccessful:
Summary of Changes
We can safely apply possible strict string comparisons where possible.
Testing Instructions
Apply patch, run all test.
Actual result BEFORE applying this Pull Request
Non-strict string comparisons.
Expected result AFTER applying this Pull Request
All good.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_associations com_banners com_categories com_checkin com_config com_contact com_content |
| Labels |
Added:
PR-5.3-dev
|
||
| Title |
|
||||||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-08-16 14:25:20 |
| Closed_By | ⇒ | Denitz | |
| Labels |
Added:
Feature
Conflicting Files
PR-6.0-dev
Removed: PR-5.3-dev |
||
@brianteeman Thanks for being the first who has spotted this PR!
Sorry, but I am closing this PR. No time and no sense to fix conflicts since Oct 18, 2024 and v5.3.
I will probably make a new PR once 6.0.0 is released, even though I don't see any demand for it.
Actually, all these simple PRs originated from simple PHP inspections can be easily merged by Joomla code owners.
I am sure that not less than 60% of static code analysis problems can be resolved in 2-3 hours, if somebody with merge permission just use PHPStorm, even with built-in inspections, or even better with "Php Inspections (EA Extended) plugin". At least before releasing 6.0.0 when the new features are frozen.
This pull request has been automatically rebased to 6.0-dev.