Pending

User tests: Successful: Unsuccessful:

avatar kyleledbetter
kyleledbetter
25 Sep 2012
  • adding Site Title and Description param as fallbacks if there is no Site Logo present
  • also fixing a couple of responsive display issues
avatar kyleledbetter kyleledbetter - open - 25 Sep 2012
avatar infograf768
infograf768 - comment - 25 Sep 2012

Fixed in master with some changes. See tracker.

avatar infograf768 infograf768 - close - 25 Sep 2012
avatar nternetinspired
nternetinspired - comment - 25 Sep 2012

@infograf768 A link to the commit and the tracker item would be a big help. Your comment is not very illuminating...

avatar kyleledbetter
kyleledbetter - comment - 25 Sep 2012

@nternetinspired Seth this solution works decently well and gives the end user the ability to change the Google font or not use one, but I like the OneWeb solution you posted. Let's chat about that and other semantic improvements for 3.1, which needs to start right away :)

avatar nternetinspired
nternetinspired - comment - 25 Sep 2012

I can't deny it works, I just don't think inline styling the css along with the font call is most sensible option, for two reasons;

1) Inline styling should be avoided wherever possible, as modern best practice dictates.
2) It makes modification far more difficult for the end user. Imagine if they select a Google font they want to only use for the logo; the inline styling will also apply it to all header elements. That behaviour can only be overcome by editing index.php

As the styling was previously, a user could modify which fonts were applied to which element by modifying only the css. Styling should reside in stylesheets (and their LESS parents ofc).

avatar nternetinspired
nternetinspired - comment - 25 Sep 2012

More than happy to chat about improvements for 3.1. I've been creating my own content overrides for 3.0 today, and I'm more than happy to share.

There are also a number of open issues in this regard, key among them is #358

p.s. Thanks for replying here @kyleledbetter , it's so much more usable than Joomlacode. :)

avatar kyleledbetter
kyleledbetter - comment - 25 Sep 2012

I'd love to see all the frontend views get the same HTML5 treatment for 3.1, hoping I can count on you and Matt for that. Let's take that message offline since we're hijacking this thread :)

Add a Comment

Login with GitHub to post a comment