[#44283] - [5.2] SEF URLs: Check if SEF plugin is published
- Fixed in Code Base
- 3 Nov 2024
- Medium
- Build: 5.2-dev
- # 44283
- Diff
- Hackwar:5.2-sef-plugin
User tests: Successful: Unsuccessful:
Pull Request for Issue #44270.
Summary of Changes
The new changes for SEF URLs check the options in the SEF plugin. If the plugin is unpublished/disabled, the plugin data is not loaded and results in notices in the output if error reporting is turned up high enough.
Testing Instructions
Install 5.2 and set error reporting to maximum, as well as debugging to on. Unpublish the SEF system plugin.
Actual result BEFORE applying this Pull Request
Warning: Attempt to read property "params" on array in [ROOT]libraries/src/Component/Router/Rules/MenuRules.php
Expected result AFTER applying this Pull Request
Nothing.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Front End Libraries |
That is the goal of this PR to allow this.
| Labels |
Added:
bug
PR-5.2-dev
|
||
I have tested this item ✅ successfully on 1ac14e8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44283.
I have tested this item ✅ successfully on 1ac14e8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44283.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44283.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-11-03 18:34:45 |
| Closed_By | ⇒ | pe7er |
I am not up to date with 3rd party sef extensions but what if they require the core sef plugin to be disabled?