bug PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
16 Oct 2024

Pull Request for Issue #44270.

Summary of Changes

The new changes for SEF URLs check the options in the SEF plugin. If the plugin is unpublished/disabled, the plugin data is not loaded and results in notices in the output if error reporting is turned up high enough.

Testing Instructions

Install 5.2 and set error reporting to maximum, as well as debugging to on. Unpublish the SEF system plugin.

Actual result BEFORE applying this Pull Request

Warning: Attempt to read property "params" on array in [ROOT]libraries/src/Component/Router/Rules/MenuRules.php

Expected result AFTER applying this Pull Request

Nothing.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 16 Oct 2024
avatar Hackwar Hackwar - change - 16 Oct 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Oct 2024
Category com_tags Front End Libraries
avatar brianteeman
brianteeman - comment - 16 Oct 2024

I am not up to date with 3rd party sef extensions but what if they require the core sef plugin to be disabled?

avatar Hackwar
Hackwar - comment - 17 Oct 2024

That is the goal of this PR to allow this.

avatar Hackwar Hackwar - change - 24 Oct 2024
Labels Added: bug PR-5.2-dev
avatar fgsw fgsw - test_item - 24 Oct 2024 - Tested successfully
avatar fgsw
fgsw - comment - 24 Oct 2024

I have tested this item ✅ successfully on 1ac14e8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44283.

Add a Comment

Login with GitHub to post a comment