PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar rdeutz
rdeutz
15 Oct 2024

Summary of Changes

Implementing changes to our codebase regarding depreciated code. Done by component and splited into back and frontend for easier testing.

Testing Instructions

Test the backend for the action log component. Test also other componets e.g. user who add information to the action log.

Actual result BEFORE applying this Pull Request

Anything works

Expected result AFTER applying this Pull Request

Anything works

avatar rdeutz rdeutz - open - 15 Oct 2024
avatar rdeutz rdeutz - change - 15 Oct 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Oct 2024
Category Administration
avatar rdeutz rdeutz - change - 15 Oct 2024
Title
[5.2] Deprecations: Changes we can make with 5.3
[5.3] Deprecations: Changes we can make with 5.3
avatar rdeutz rdeutz - edited - 15 Oct 2024
avatar rdeutz rdeutz - change - 15 Oct 2024
Labels Added: PR-5.3-dev
avatar brianteeman
brianteeman - comment - 15 Oct 2024

Can you please update the PR title so that it is clearer what is being changed here.

avatar rdeutz rdeutz - change - 15 Oct 2024
Title
[5.3] Deprecations: Changes we can make with 5.3
[5.3] Deprecations: Changes we can make with 5.3 for the actionlog component (Backend)
avatar rdeutz rdeutz - edited - 15 Oct 2024
avatar HLeithner
HLeithner - comment - 16 Oct 2024

@brianteeman what's the issue when removing (C) ? the @copyright already says that it's about the copyright isn't it?
as alternative we could use © can't we? just asking

avatar brianteeman
brianteeman - comment - 16 Oct 2024

@brianteeman what's the issue when removing (C) ? the @copyright already says that it's about the copyright isn't it? as alternative we could use © can't we? just asking

  1. We should only use one form of copyright statement throughout Joomla
  2. In many countries - including the USA - the @copyright "element" does not match the legal requirements of a copyright statement
  3. Using © instead of (c) is ok but we must be consistent

I can provide more legal references if required

avatar rdeutz
rdeutz - comment - 17 Oct 2024

@brianteeman using "Copyright" as word should also be ok, right? But I am looking what is the best way in terms of IDE configuration.

avatar brianteeman
brianteeman - comment - 17 Oct 2024

@brianteeman using "Copyright" as word should also be ok, right? But I am looking what is the best way in terms of IDE configuration.

In the USA it would be ok - not sure about elsewhere. We should be consistent though.

avatar rdeutz
rdeutz - comment - 17 Oct 2024

I did it again on another way, so anything should be fine now and the PR can be tested

avatar brianteeman
brianteeman - comment - 17 Oct 2024

I am confused about this codestyle as it doesnt appear to be consistent

        if (!empty($extension)) {
            $extension .= '%';
            $query
                ->where($db->quoteName('a.extension') . ' LIKE :extension')
                ->bind(':extension', $extension);
        }
                $query->where(
                    $db->quoteName('a.log_date') . ' BETWEEN :dstart AND :dnow',
                );
                $query->bind(':dstart', $dStart);
                $query->bind(':dnow', $dNow);

In the second one shouldnt the two bind queries be part of the first query - so something like

                $query
                ->where($db->quoteName('a.log_date') . ' BETWEEN :dstart AND :dnow')
                ->bind(':dstart', $dStart);
                ->bind(':dnow', $dNow);
avatar rdeutz
rdeutz - comment - 17 Oct 2024

I missed the whole file.

About the code style for multiline chaining. Honestly I am not 100% sure what it better readable. The reformat applies when you have something like

$var->action1()
  ->action2()
  ->action3()

then it is converted into

$var
  ->action1()
  ->action2()
  ->action3()

It might be better to let it as it is, the difference is not so big

Add a Comment

Login with GitHub to post a comment