RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar rdeutz
rdeutz
14 Oct 2024

Pull Request for Issue #44250

Summary of Changes

Added missing $this->state = $model->getState();

Testing Instructions

  • Install 5.3 current dev or alpha1
  • Add new menu item
  • Select Menutype

Actual result BEFORE applying this Pull Request

See issue #444250

Expected result AFTER applying this Pull Request

No error

D38A770B-804F-4F2F-8747-34639269CB8D

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

fcd41dd 14 Oct 2024 avatar rdeutz fix
avatar rdeutz rdeutz - open - 14 Oct 2024
avatar rdeutz rdeutz - change - 14 Oct 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Oct 2024
Category Administration com_menus
avatar fgsw fgsw - test_item - 14 Oct 2024 - Tested successfully
avatar fgsw
fgsw - comment - 14 Oct 2024

I have tested this item ✅ successfully on fcd41dd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44251.

avatar fontanil fontanil - test_item - 14 Oct 2024 - Tested successfully
avatar fontanil
fontanil - comment - 14 Oct 2024

I have tested this item ✅ successfully on fcd41dd

Tested successfully on 5.3.0 alpha1 dev (nightly build)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44251.

avatar alikon alikon - change - 14 Oct 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 14 Oct 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44251.

avatar richard67 richard67 - change - 14 Oct 2024
Status Ready to Commit Pending
Labels Added: PR-5.3-dev
avatar richard67
richard67 - comment - 14 Oct 2024

Back to pending due to review comment


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44251.

avatar richard67 richard67 - alter_testresult - 15 Oct 2024 - fgsw: Tested successfully
avatar richard67 richard67 - alter_testresult - 15 Oct 2024 - fontanil: Tested successfully
avatar richard67
richard67 - comment - 15 Oct 2024

I've restored the previous human test results in the issue tracker as the changes after the tests which have invalidated the test counter do not have a functional impact, they only fix a deprecation notice.

avatar richard67 richard67 - change - 15 Oct 2024
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 15 Oct 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44251.

avatar laoneo laoneo - change - 15 Oct 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-10-15 10:19:01
Closed_By laoneo
Labels Added: RTC
avatar laoneo laoneo - close - 15 Oct 2024
avatar laoneo laoneo - merge - 15 Oct 2024
avatar laoneo
laoneo - comment - 15 Oct 2024

Thanks!

Add a Comment

Login with GitHub to post a comment