Feature Language Change PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
13 Oct 2024

Pull Request for Issue #43872 .

Summary of Changes

use the mail template instead of com_messages

Testing Instructions

apply the database changes from the update SQL script e.g. with phpMyAdmin, or to use the update package
send an article from frontend and check the email

Actual result BEFORE applying this Pull Request

N/A

Expected result AFTER applying this Pull Request

the email is configurable with Mailtemplates

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

af41078 13 Oct 2024 avatar alikon synch
70c36d4 13 Oct 2024 avatar alikon clean
avatar alikon alikon - open - 13 Oct 2024
avatar alikon alikon - change - 13 Oct 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Oct 2024
Category SQL Administration com_admin Postgresql Language & Strings Installation Front End Plugins
avatar alikon alikon - change - 13 Oct 2024
Labels Added: Language Change PR-5.3-dev
avatar alikon alikon - change - 14 Oct 2024
The description was changed
avatar alikon alikon - edited - 14 Oct 2024
avatar alikon alikon - change - 14 Oct 2024
Title
[wip] Newarticle2mailtemplate
[5.3] New article from frontend send mail with Mailtemplate
avatar alikon alikon - edited - 14 Oct 2024
avatar Kostelano Kostelano - test_item - 14 Oct 2024 - Tested successfully
avatar Kostelano
Kostelano - comment - 14 Oct 2024

I have tested this item ✅ successfully on db74a7f

Before PR: article creation ---> email notification that there is a personal message. In the personal message in the panel there is information about a new article that was created by this and that.

After PR: article creation ---> email notification that such and such an article was created, written by that and that.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44243.

avatar alikon alikon - change - 27 Jan 2025
Labels Added: Feature
avatar komalm komalm - test_item - 22 Feb 2025 - Tested unsuccessfully
avatar komalm
komalm - comment - 22 Feb 2025

I have tested this item 🔴 unsuccessfully on 014ac4e

Tested on: Joomla! 5.3-dev
Patch Applied Using: Joomla! Patch Tester

Steps Followed for Testing:

  • Applied the patch via Patch Tester.
  • Verified that mail settings are correctly configured.
  • Submitted a new article from the frontend.
  • Checked the email inbox for notifications.

Issue Observed:

avatar crommie crommie - test_item - 22 Feb 2025 - Tested unsuccessfully
avatar crommie
crommie - comment - 22 Feb 2025

I have tested this item 🔴 unsuccessfully on 014ac4e

Tested on: Joomla! 5.3-dev on the test server
Patch Applied Using: Joomla! Patch Tester

Before: email was sent with mail template
After: email was sent with mail template


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44243.

avatar alikon
alikon - comment - 22 Feb 2025

thanks for testing and for feedback
it was working in October 24 😄

i'll re-check and i'll make it after available for test again

avatar richard67
richard67 - comment - 22 Feb 2025

@alikon You have to rename the update SQL scripts to something newer than the newest in the branch, which is 5.3.0-2025-02-09.sql, so rename to e.g. 5.3.0-2025-02-22.sql. That'S the reason why your update SQL does not run when people update with the patched package from Drone.

And the PR has a conflict which needs to be resolved. If necessary I can help, but not before tonight.

avatar richard67
richard67 - comment - 22 Feb 2025

@komalm @crommie As this PR also makes database changes, it is not enought to apply the patch with patch tester, it also needs to apply the database changes from the update SQL script e.g. with phpMyAdmin, or to use the update package created by Drone, but that would currently not work, see my previous comment for explanation.

@alikon Please update your testing instructions to make that clear.

avatar crommie
crommie - comment - 22 Feb 2025

Plus the notifications were already using the email templates without the patch.

avatar alikon
alikon - comment - 23 Feb 2025

as there is no entry in the #__mail_templates table before this pr on the current 5.3-dev branch
i really doubt that notification for this event use the mail template
@crommie can you clarify how you got that ?

avatar alikon alikon - change - 23 Feb 2025
The description was changed
avatar alikon alikon - edited - 23 Feb 2025
82aa777 23 Feb 2025 avatar alikon phpcs
avatar crommie
crommie - comment - 23 Feb 2025

Only scenario I can think of is: I might have fired the scheduled task without enabling email, then got confused, then enabled email, applied patch, fired task, got email from email template, reverted patch, fired task and got email from template again.

The only part I'm 100% sure of is I did fire it both with patch applied and with patch reverted and in both cases it used email template.

avatar crommie
crommie - comment - 23 Feb 2025

Only scenario I can think of is: I might have fired the scheduled task without enabling email, then got confused, then enabled email, applied patch, fired task, got email from email template, reverted patch, fired task and got email from template again.

The only part I'm 100% sure of is I did fire it both with patch applied and with patch reverted and in both cases it used email template.

avatar crommie
crommie - comment - 23 Feb 2025

You want me to test again on a clean site? And if so: are the PBF sites still there?

avatar HLeithner
HLeithner - comment - 4 Mar 2025

This pull request has been automatically rebased to 6.0-dev.

avatar HLeithner HLeithner - change - 4 Mar 2025
Title
[5.3] New article from frontend send mail with Mailtemplate
[6.0] New article from frontend send mail with Mailtemplate
avatar HLeithner HLeithner - edited - 4 Mar 2025
avatar alikon alikon - change - 7 Mar 2025
Labels Added: PR-6.0-dev
Removed: PR-5.3-dev
avatar alikon alikon - close - 24 Mar 2025
avatar alikon
alikon - comment - 24 Mar 2025

i'll not invest much more time on this

avatar alikon alikon - change - 24 Mar 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-03-24 21:46:30
Closed_By alikon

Add a Comment

Login with GitHub to post a comment