Feature Language Change PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
12 Oct 2024

Summary of Changes

This PR moves the CMS Filesystem classes to the compat plugin, allowing legacy third party code to still run when the plugin is active, but making the first step to finally remove it from the CMS.

I've added the Composer Dependency Changed label because the PR requires composer i to be run.

Testing Instructions

Copy the following line in a view of your choice to generate a call to the legacy classes:

var_dump(\Joomla\CMS\Filesystem\Folder::listFolderTree(JPATH_BASE, '.'));

Make sure the compat plugin is enabled AND you have to run composer i to generate an updated class loader file
Visit the view you edited in the browser to see an output of the call to the legacy class. Disable the plugin and see an error thrown instead.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 12 Oct 2024
avatar Hackwar Hackwar - change - 12 Oct 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Oct 2024
Category Front End Plugins
avatar Hackwar Hackwar - change - 12 Oct 2024
The description was changed
avatar Hackwar Hackwar - edited - 12 Oct 2024
avatar Hackwar Hackwar - change - 12 Oct 2024
Labels Added: Feature Composer Dependency Changed PR-6.0-dev
avatar laoneo
laoneo - comment - 14 Oct 2024

Please move the "classes" folder outside of the src folder. Like it is now you have the src folder managed by a classloader and then the "classes" folder managed by another classloader. I would also rename the "classes" folder to legacy or so.

avatar Hackwar Hackwar - change - 14 Oct 2024
Labels Removed: Composer Dependency Changed
avatar joomla-cms-bot joomla-cms-bot - change - 14 Oct 2024
Category Front End Plugins Administration Language & Strings Front End Plugins
avatar Hackwar Hackwar - change - 14 Oct 2024
Labels Added: Language Change
avatar Hackwar
Hackwar - comment - 14 Oct 2024

Done

Add a Comment

Login with GitHub to post a comment