[#44238] - [5.3] Change type of field "fieldparams" in table #_fields from text to mediumtext
- Fixed in Code Base
- 14 Oct 2024
- Medium
- Build: 5.3-dev
- # 44238
- Diff
- alikon:mediumtext
User tests: Successful: Unsuccessful:
Pull Request for Issue #43929 .
Summary of Changes
alter #__fields.fieldparams to MEDIUMTEXT
Testing Instructions
run the sql
ALTER TABLE `#__fields` MODIFY `fieldparams` MEDIUMTEXT NOT NULL;
or
https://artifacts.joomla.org/drone/joomla/joomla-cms/5.3-dev/44238/downloads/79556/
Actual result BEFORE applying this Pull Request
the field is TEXT
Expected result AFTER applying this Pull Request
the field is MEDIUMTEXT
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Installation |
| Title |
|
||||||
| Labels |
Added:
PR-5.3-dev
|
||
I've restored the previous human test result as the later changes which have invalidated the test counter were only some kind of code style without functional impact.
I have tested this item ✅ successfully on 8270392
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44238.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44238.
Do we not need the changes on postgres too?
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-10-14 08:34:59 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
RTC
|
||
Thanks!
Oh, hold on, why? It is mistake.
We should not encourage developers to store huge amount of data in parameters.
Extensions, modules, templates, menu, have the text type for parameters, why fields hould be diferent?
This here is more about end users and not extension developers as the fieldparams column contains the options from the UI.
I have tested this item ✅ successfully on 03a0fab
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44238.