[#44212] - 5.2 dev Fix breadcrumbs color in light and darkmode, fix for 44134
- Fixed in Code Base
- 3 Feb 2025
- Medium
- Build: 52-dev
- # 44212
- Diff
- coolcat-creations:5.2-dev-fix-breadcrumbs
User tests: Successful: Unsuccessful:
Pull Request for Issue #44134 .
Summary of Changes
Assiged body color to the last item of breadcrumbs
Testing Instructions
Download the test package
Navigate to media manager
navigate into a deeper folder
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
[ x] No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
[ x] No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration com_admin SQL |
Almost but not quite. The text is now visible but the border is still invisible
Shouldn't the border be rather removed in dark? It's the last item
| Labels |
Added:
Unit/System Tests
PR-5.2-dev
|
||
| Category | Unit Tests Repository Administration com_admin SQL | ⇒ | Repository NPM Change |
I removed the border from the last item generally because the border is shaped like an arrow and implies that something on the right of it is not visible
I have tested this item ✅ successfully on 2696d61
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44212.
@brianteeman — why thumbs down? In normal breadcrumbs, you don't have an arrow icon after the last item either?
@brianteeman — why thumbs down? In normal breadcrumbs, you don't have an arrow icon after the last item either?
because it was an intentional design decision to visually style the breadcrumbs in this way
But its wrong ?
@coolcat-creations I think it is better with border. Because without border it looks like text floating nowhere, and design of this element looks like incomplete.
And when it not the last folder in the tree the "chevron" suggests that User can go deeper, kind of 😉
| Labels |
Added:
NPM Resource Changed
bug
Removed: Unit/System Tests |
||
| Labels |
Added:
RMDQ
|
||
I have tested this item ✅ successfully on 5d8c411
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44212.
| Status | Pending | ⇒ | Ready to Commit |
| Build | 4.4-dev | ⇒ | 52-dev |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44212.
Maintainers have decided to merge this for now , as the visibility of the text is important. The border should be re-added also for light mode. It would be great if you can re-add the border, @coolcat-creations.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-03 10:49:32 |
| Closed_By | ⇒ | Hackwar | |
| Labels |
Added:
RTC
|
||
Thank you for this fix!
I have tested this item ✅ successfully on b62a2c6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44212.