[#4421] - Fix renderModules error when getTemplate called with true from included module templates
- Closed
- 21 Aug 2015
- Medium
- Build: staging
- # 4421
- Diff
- haydenyoung:patch-20141001-getModule-incorrect-template
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
When getTemplate(true) is called from a module override (i.e. to retrieve template params), JModuleHelper renderModules method breaks because the $template variable's value has changed from a string (the name of the template) to an object (holding the template's params) between being assigned and when actually called. This is due to module overrides being called after the variable has been assigned a value but before it is used by the chrome and attribs vars.
Instead of assigning to a $template var, getTemplate is called directly to ensure the template name is available rather than the stdClass.
jissues-bot
- | Labels |
Added:
?
|
||
infograf768
- 
brianteeman
- | Category | ⇒ | Libraries |
Blutengel89
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-08-21 12:26:55 |
| Closed_By | ⇒ | roland-d |
With 2 unsuccessful tests and the topic starter removed the repository I am closing this issue. Feel free to open the issue at anytime if you want to continue.
Thank you for your contribution.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4421.
I couldn't reproduce the problem with the break of the function. The value of $template doesn't change from a string to an object. In my tests it always stayed as a string and the function didn't break. So the test was not successful, because there is no problem to reproduce.