Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#44202] - [5.2] Articles Module: Display not only titles by default

RTC PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
7 Oct 2024

Summary of Changes

The Articles module right now is set to only display titles by default and then hides all other options. This is confusing and this PR switches that behavior around.

Testing Instructions

Create a new Articles module instance.

Actual result BEFORE applying this Pull Request

You only see the option "Show titles only" being set to "Yes". Rest is hidden.

Expected result AFTER applying this Pull Request

Option "Show titles only" is set to "No" by default and all other options are displayed.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 7 Oct 2024
avatar Hackwar Hackwar - change - 7 Oct 2024
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Oct 2024
Category ⇒ Modules Front End
avatar fgsw fgsw - test_item - 8 Oct 2024 - Tested successfully
avatar fgsw
fgsw - comment - 8 Oct 2024

I have tested this item ✅ successfully on c5b50da

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44202.

avatar richard67
richard67 - comment - 8 Oct 2024

Update https://github.com/Hackwar/joomla-cms/blob/c5b50dacf4d0fa244ab14ed1d7bb8bb46d89a6cb/modules/mod_articles/tmpl/default.php#L36

@Hackwar Quy is right, it needs to change the default value from 1 to 0 in that line.

avatar dautrich dautrich - test_item - 8 Oct 2024 - Tested successfully
avatar dautrich
dautrich - comment - 8 Oct 2024

I have tested this item ✅ successfully on c5b50da

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44202.

avatar Hackwar Hackwar - change - 8 Oct 2024
Labels Added: Updates Requested PR-5.2-dev
avatar Hackwar
Hackwar - comment - 8 Oct 2024

I changed the second parameter as well.

avatar richard67 richard67 - alter_testresult - 8 Oct 2024 - fgsw: Tested successfully
avatar richard67 richard67 - alter_testresult - 8 Oct 2024 - dautrich: Tested successfully
avatar richard67
richard67 - comment - 8 Oct 2024

I've restored the previous human test results in the issue tracker as the commit which has invalidated the test count has no functional impact on the tests.

avatar richard67 richard67 - change - 8 Oct 2024
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 8 Oct 2024

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44202.

avatar Quy Quy - change - 8 Oct 2024
Labels Added: RTC
Removed: Updates Requested
avatar bembelimen bembelimen - change - 8 Oct 2024
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-10-08 14:06:29
Closed_By ⇒ bembelimen
avatar bembelimen bembelimen - close - 8 Oct 2024
avatar bembelimen bembelimen - merge - 8 Oct 2024
avatar bembelimen
bembelimen - comment - 8 Oct 2024

Thx

Add a Comment

Login with GitHub to post a comment