? Success

User tests: Successful: Unsuccessful:

avatar haydenyoung
haydenyoung
1 Oct 2014

The library description is not being translated when installing a 3rd party library via the Extension Manager. Additionally the library name is hardcoded (i.e. cannot be translated). These problems are due to the incorrect naming of the language file when it is being loaded.

The pull request adds correct loading of the library language sys file during installation and when displaying the library name in the Manage page.

avatar haydenyoung haydenyoung - open - 1 Oct 2014
avatar jissues-bot jissues-bot - change - 1 Oct 2014
Labels Added: ?
avatar vdespa
vdespa - comment - 1 Oct 2014

This is not a bug. See #2796.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4418.

avatar haydenyoung
haydenyoung - comment - 1 Oct 2014

So library name and description should be hardcoded? This doesn't seem correct.

avatar vdespa
vdespa - comment - 1 Oct 2014

I understand your confusion. Last time I checked there are some dependencies in the installer regarding this. Will leave your PR open for review / testing.

avatar phproberto phproberto - close - 2 Oct 2014
avatar phproberto phproberto - change - 2 Oct 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-10-02 00:29:31
avatar vdespa
vdespa - comment - 3 Oct 2014

@phproberto - could you please explain what did you merge here? I don't understand.

avatar haydenyoung
haydenyoung - comment - 16 Oct 2014

@phproberto @vdespa I just wanted to confirm whether this has been correctly merged. @vdespa raised concerns about dependencies in the installer.

avatar betweenbrain
betweenbrain - comment - 17 Oct 2014

696b4c2 seems to have been from @mbabker for development purposes. Maybe this was closed by mistake?

@haydenyoung are you proposing any file changes?

Add a Comment

Login with GitHub to post a comment