RTC PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar conseilgouz
conseilgouz
2 Oct 2024

Mod_Articles : if show introtext parameter is set with an introtext limit greater than 0, a wrong value is displayed in the module.

Summary of Changes

In ArticlesHelper.php, show_introtext fills up displayIntrotext field (lines 362 to 373), but default_items.php displays introtext field (line 107).

Testing Instructions

In Articles module, set IntroText parameter to Show and set IntroText Limit to any non-zero value.

Actual result BEFORE applying this Pull Request

Articles module shows full article

Expected result AFTER applying this Pull Request

Articles module shows truncated articles to the defined limit.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar conseilgouz conseilgouz - open - 2 Oct 2024
avatar conseilgouz conseilgouz - change - 2 Oct 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Oct 2024
Category Modules Front End
avatar fgsw
fgsw - comment - 2 Oct 2024

@conseilgouz Can you add [5.2] to the title so user don't have to open the Pull Request to know which branche it is for?

avatar conseilgouz conseilgouz - change - 2 Oct 2024
Title
mod_articles : show introtext not working
[5.2] mod_articles : show introtext not working
avatar conseilgouz conseilgouz - edited - 2 Oct 2024
avatar conseilgouz conseilgouz - change - 2 Oct 2024
Title
[5.2] mod_articles : show introtext not working
[5.2-RC] mod_articles : show introtext not working
avatar conseilgouz conseilgouz - edited - 2 Oct 2024
avatar drmenzelit
drmenzelit - comment - 2 Oct 2024

#44132 introduced the wrong line ... it was correct before...

avatar Kostelano Kostelano - test_item - 2 Oct 2024 - Tested successfully
avatar Kostelano
Kostelano - comment - 2 Oct 2024

I have tested this item ✅ successfully on 7a9b13e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44179.

avatar RickR2H RickR2H - test_item - 2 Oct 2024 - Tested successfully
avatar RickR2H
RickR2H - comment - 2 Oct 2024

I have tested this item ✅ successfully on 7a9b13e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44179.

avatar RickR2H RickR2H - change - 2 Oct 2024
Status Pending Ready to Commit
avatar RickR2H
RickR2H - comment - 2 Oct 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44179.

avatar conseilgouz conseilgouz - change - 4 Oct 2024
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2024-10-04 12:41:00
Closed_By conseilgouz
Labels Added: RTC PR-5.2-dev
avatar conseilgouz conseilgouz - close - 4 Oct 2024

Add a Comment

Login with GitHub to post a comment