NPM Resource Changed PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
29 Sep 2024

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the following NPM dependencies which are used for development:

  • node_modules/braces from 3.0.2. to 3.0.3
  • node_modules/fill-range (indirect dependency from braces) from 7.0.1 to 7.1.1
  • node_modules/micromatch (indirect dependency from braces) from 4.0.5 to 4.0.8
  • node_modules/rollup from 2.79.1 to 2.79.2

This fixes 3 issues reported by npm audit.

Hint for 5.2 release managers: These changes don't need to be merged up into 5.2-dev as the mentioned dependencies have been updated there already with other PRs. So on the next upmerge if there is a conflict with this, just use what's on 5.2-dev.

Testing Instructions

Check e.g. in Drone if npm and the upload package build still succeed, and check the detailed log in Drone for one of these 2 regarding issues reported by npm audit.

Actual result BEFORE applying this Pull Request

Works, but npm audit reports 3 issues which can be fixed with npm audit fix (and one for TinyMCE < 7 which is a known false alarm).

Expected result AFTER applying this Pull Request

Works, and npm audit doesn't report these 3 issues anymore.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 29 Sep 2024
avatar richard67 richard67 - change - 29 Sep 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Sep 2024
Category NPM Change
avatar richard67 richard67 - change - 29 Sep 2024
The description was changed
avatar richard67 richard67 - edited - 29 Sep 2024
avatar richard67 richard67 - change - 29 Sep 2024
The description was changed
avatar richard67 richard67 - edited - 29 Sep 2024
avatar richard67 richard67 - change - 29 Sep 2024
The description was changed
avatar richard67 richard67 - edited - 29 Sep 2024
avatar MacJoom MacJoom - close - 30 Sep 2024
avatar MacJoom MacJoom - merge - 30 Sep 2024
avatar MacJoom MacJoom - change - 30 Sep 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-09-30 19:47:19
Closed_By MacJoom
Labels Added: NPM Resource Changed PR-4.4-dev
avatar MacJoom
MacJoom - comment - 30 Sep 2024

Thank you!

Add a Comment

Login with GitHub to post a comment