Language Change PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar conseilgouz
conseilgouz
29 Sep 2024

Summary of Changes

In mod_articles_news, there's a trigger event onContentPrepare (line 170 in ArticlesNewsHelper.php).

It's missing in mod_modules.

This PR adds this missing event.

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar conseilgouz conseilgouz - open - 29 Sep 2024
avatar conseilgouz conseilgouz - change - 29 Sep 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Sep 2024
Category Modules Front End
avatar Kostelano
Kostelano - comment - 29 Sep 2024

If this should be controlled by this option, please add the information to the language line:

MOD_ARTICLES_FIELD_TRIGGER_EVENTS_DESC="Enable this option to trigger three plugin events (afterDisplayTitle, beforeDisplayContent, afterDisplayContent) for each article in the results list."

avatar conseilgouz conseilgouz - change - 29 Sep 2024
Labels Added: PR-5.2-dev
avatar joomla-cms-bot joomla-cms-bot - change - 29 Sep 2024
Category Modules Front End Language & Strings Modules Front End
avatar conseilgouz
conseilgouz - comment - 29 Sep 2024

mod_articles.ini file has been updated.
@Kostelano : thank you for telling me about this.

avatar Fedik
Fedik - comment - 2 Oct 2024

The event already trigered by

$item->displayIntrotext = HTMLHelper::_('content.prepare', $item->introtext, '', 'mod_articles.content');

But only for text

avatar conseilgouz
conseilgouz - comment - 2 Oct 2024

The event is triggered only for displayIntroText.
If any other item field is affected by this event, it will not be done.

avatar Fedik
Fedik - comment - 2 Oct 2024

The event is triggered only for displayIntroText.

Yeah.

The problem, that the event will be triggered TWICE now.
This need a complex solution.

avatar Fedik
Fedik - comment - 2 Oct 2024

The problem, that the event will be triggered TWICE now.
This need a complex solution.

avatar conseilgouz conseilgouz - change - 3 Oct 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-10-03 08:45:45
Closed_By conseilgouz
Labels Added: Language Change
avatar conseilgouz conseilgouz - close - 3 Oct 2024

Add a Comment

Login with GitHub to post a comment