RTC Language Change PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar drmenzelit
drmenzelit
26 Sep 2024

Pull Request for Issue # .

Summary of Changes

Added the option for dynamic mode as it was in mod_articles_category

Testing Instructions

Create a module selecting dynamic mode. Create some menu items for different categories and check if the module display the articles of the category dynamically

Inline help:

Please select the mode you would like to use. If Normal Mode is chosen, then configure the module and it will display a static list of Articles on the menu items you assign the module to. If Dynamic Mode is chosen, then you can still configure the module normally, however now the Category option will no longer be used. Instead, the module will dynamically detect if you are on a Category view and will display the list of articles within that Category. When Dynamic Mode is chosen, it is best to leave the module set to display on all pages, as it will decide to display anything dynamically.

Actual result BEFORE applying this Pull Request

No dynamic mode present

Expected result AFTER applying this Pull Request

The module display a list of articles depending on the category from the menu item

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar drmenzelit drmenzelit - open - 26 Sep 2024
avatar drmenzelit drmenzelit - change - 26 Sep 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Sep 2024
Category Language & Strings Modules Front End Plugins
avatar drmenzelit drmenzelit - change - 26 Sep 2024
Labels Added: Language Change PR-5.2-dev
avatar Kostelano
Kostelano - comment - 26 Sep 2024

Sorry, I wrote about the need to change the demo data plugin, but I didn't notice that it was already done.

avatar RickR2H RickR2H - test_item - 27 Sep 2024 - Tested successfully
avatar RickR2H
RickR2H - comment - 27 Sep 2024

I have tested this item ✅ successfully on 28cc184


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44145.

avatar Bodge-IT Bodge-IT - test_item - 28 Sep 2024 - Tested successfully
avatar Bodge-IT
Bodge-IT - comment - 28 Sep 2024

I have tested this item ✅ successfully on 28cc184

Tested on Cat Blog & List menu items.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44145.

avatar alikon alikon - change - 28 Sep 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 28 Sep 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44145.

avatar Hackwar Hackwar - change - 28 Sep 2024
Labels Added: RTC
avatar brianteeman
brianteeman - comment - 28 Sep 2024

I thought we were in a language freeze for 5.2?

avatar Hackwar
Hackwar - comment - 28 Sep 2024

Yes, we are. And I'm unhappy with all of this, but the alternative is that we revert the whole articles module.

avatar Hackwar Hackwar - change - 28 Sep 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-09-28 18:24:26
Closed_By Hackwar
avatar Hackwar Hackwar - close - 28 Sep 2024
avatar Hackwar Hackwar - merge - 28 Sep 2024
avatar Hackwar
Hackwar - comment - 28 Sep 2024

Thank you for your contribution @drmenzelit!

avatar brianteeman
brianteeman - comment - 28 Sep 2024

Yes, we are. And I'm unhappy with all of this, but the alternative is that we revert the whole articles module.

No - the alternative was to add dynamic mode as a new feature in a future release.

There is/was zero urgency at all to merge this

Add a Comment

Login with GitHub to post a comment