[#44142] - [5.2] Fix filtering exclude and include articles
- Fixed in Code Base
- 27 Sep 2024
- Medium
- Build: 5.2-dev
- # 44142
- Diff
- rdeutz:article-mod-subform
User tests: Successful: Unsuccessful:
Summary of Changes
The new article model has a article id filtering, it was a simple text field where you could add ids. This is changed to a subform with a article modal to chose articles. Further more it is not possible to exclude and include articles by id at the same time.
I have changed the configuration of the module so that is only allow what is possible.
Exclude Mode
Include Mode
Testing Instructions
Try to exclude some articles and include some articles. Check if the module show the expected articles.
Expected result AFTER applying this Pull Request
Module shows the expected articles
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Language & Strings Modules Front End |
| Labels |
Added:
Language Change
PR-5.2-dev
|
||
I got an error testing the PR:
I have tested this item ✅ successfully on df87c15
Thank you Robert!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44142.
The module parameters are also used in the plugin with demo data. We probably need to make changes in file plugins/sampledata/blog/src/Extension/Blog.php, because demo data creates 3 modules of type ARTICLES after installation.
UPD
Or do it after merging about 5 new PRs for this module.
I have tested this item ✅ successfully on df87c15
Works! The tabs ans spaces issue has be resolved but that has no influence on the test results. please restore test results when the spacing issue is solved.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44142.
I have tested this item ✅ successfully on efdf4bc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44142.
I have tested this item ✅ successfully on efdf4bc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44142.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44142.
I do not think it is correct that the option to exclude the current article is only available if you have defined a list of articles to exclude. This option should be independent of any other settings.
USE CASE
I want to include articles 1,2,3,4,5 in the module but I do not want to include the article I am currently viewing
@brianteeman Agreed, but we are in a hurry to get everything done so we have a least a stable module. This behaviour can be fixed in a new PR. I'll put it on the list of things to do regarding the module.
Less haste more speed. No reason to accept "do it later" approach ever
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-09-27 20:51:24 |
| Closed_By | ⇒ | Hackwar |
grrh
I do not think it is correct that the option to exclude the current article is only available if you have defined a list of articles to exclude. This option should be independent of any other settings.
USE CASE
I want to include articles 1,2,3,4,5 in the module but I do not want to include the article I am currently viewing
As I wrote:
Further more it is not possible to exclude and include articles by id at the same time.
You can only select true or false for
$articles->setState('filter.article_id.include', [true|false]);
If you really want to implement the use case you would have to look, if the current article is part of the list of included articles. Doable but I didn't thought so far. We can do this with 5.3.
That's a disappointing loss of functionality
Thanks for the corrections @brianteeman.