User tests: Successful: Unsuccessful:
Pull Request for Issue #44135
Fix the read more title functionality.
Toggle Read More with Title not working
Toggle Read More with Title is working and truncation of title is working
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Modules Front End |
@brianteeman This option only reflects the settings in the module. Article parameters are not respected. This could be a feature we can add in the future. @drmenzelit What do you suggest?
@brianteeman This option only reflects the settings in the module. Article parameters are not respected.
Yes that is how it should work but it does not.
My point is that the setting in the content component are preventing the setting in the module from working.
check it out yourself.
expected behaviour - module shows the readmore title
actual behaviour - module does not show the readmore title
This line is getting the params from the article - it should be getting the params from the module
Labels |
Added:
PR-5.2-dev
|
@brianteeman please test again.
other than comments about the class names this works correctly
Good spot
Without the title it should be using JGLOBAL_READ_MORE
With the title is should be using JGLOBAL_READ_MORE_TITLE
Thanks for the feedback! Hopefully fixed now.
I have tested this item ✅ successfully on e00e280
I have tested this item ✅ successfully on e00e280
Status | Pending | ⇒ | Ready to Commit |
RTC
Removed my positive test as I think this is doing it the wrong way
Labels |
Added:
RTC
bug
|
@brianteeman please test the new version.
I have tested this item ✅ successfully on a81d79c
Status | Ready to Commit | ⇒ | Pending |
Back to pending as the test by @JeroenMoolenschot has been invalidated by a later change which was not just a branch update. I will restore @brianteeman 's test result as that was just invalidated by a branch update (with a merge conflict resolved by me but that is not relevant for the test result). But the inresolved conversation should be resolved, and it needs a 2nd human test.
I have not tested this item.
Removing my test as the active makes no sense
Labels |
Removed:
RTC
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-09-29 09:16:19 |
Closed_By | ⇒ | Hackwar |
I have tested this item 🔴 unsuccessfully on b996b09
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44136.