bug PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar RickR2H
RickR2H
25 Sep 2024

Pull Request for Issue #44135

Summary of Changes

Fix the read more title functionality.

Testing Instructions

  • Toggle the function Read More with Title on and off and see if the title is shown or hidden
  • Change the Read More Limit (characters) to 15 to see if the title is shortened,

Actual result BEFORE applying this Pull Request

Toggle Read More with Title not working

Expected result AFTER applying this Pull Request

Toggle Read More with Title is working and truncation of title is working

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar RickR2H RickR2H - open - 25 Sep 2024
avatar RickR2H RickR2H - change - 25 Sep 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Sep 2024
Category Modules Front End
avatar brianteeman brianteeman - test_item - 25 Sep 2024 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 25 Sep 2024

I have tested this item 🔴 unsuccessfully on b996b09


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44136.

avatar brianteeman
brianteeman - comment - 25 Sep 2024
chrome_2AW7e91m2w.mp4
avatar RickR2H
RickR2H - comment - 25 Sep 2024

@brianteeman This option only reflects the settings in the module. Article parameters are not respected. This could be a feature we can add in the future. @drmenzelit What do you suggest?

avatar brianteeman
brianteeman - comment - 25 Sep 2024

@brianteeman This option only reflects the settings in the module. Article parameters are not respected.

Yes that is how it should work but it does not.

My point is that the setting in the content component are preventing the setting in the module from working.

check it out yourself.

  1. set the content component options to hide readmore title
  2. set the module to show readmore title

expected behaviour - module shows the readmore title
actual behaviour - module does not show the readmore title

avatar brianteeman
brianteeman - comment - 25 Sep 2024

<?php echo LayoutHelper::render('joomla.content.readmore', ['item' => $item, 'params' => $item->params, 'link' => $item->link]); ?>

This line is getting the params from the article - it should be getting the params from the module

avatar RickR2H RickR2H - change - 25 Sep 2024
Labels Added: PR-5.2-dev
avatar RickR2H
RickR2H - comment - 25 Sep 2024

@brianteeman please test again.

avatar brianteeman
brianteeman - comment - 25 Sep 2024

other than comments about the class names this works correctly

avatar JeroenMoolenschot
JeroenMoolenschot - comment - 25 Sep 2024

Thanks Rick!

One small inconsistency

The module now shows > Read more ... Title.
image

While the component shows > Read more: Title
image

Without displaying the title it works both the same

avatar brianteeman
brianteeman - comment - 25 Sep 2024

Good spot
Without the title it should be using JGLOBAL_READ_MORE
With the title is should be using JGLOBAL_READ_MORE_TITLE

avatar RickR2H
RickR2H - comment - 25 Sep 2024

Thanks for the feedback! Hopefully fixed now.

avatar brianteeman brianteeman - test_item - 25 Sep 2024 - Tested successfully
avatar brianteeman
brianteeman - comment - 25 Sep 2024

I have tested this item ✅ successfully on e00e280


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44136.

avatar JeroenMoolenschot JeroenMoolenschot - test_item - 25 Sep 2024 - Tested successfully
avatar JeroenMoolenschot
JeroenMoolenschot - comment - 25 Sep 2024

I have tested this item ✅ successfully on e00e280


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44136.

avatar RickR2H RickR2H - change - 25 Sep 2024
Status Pending Ready to Commit
avatar RickR2H
RickR2H - comment - 25 Sep 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44136.

avatar brianteeman
brianteeman - comment - 26 Sep 2024

I think it would be better to do this the way that @rdeutz has done with #43457 - that way you can still use the layout etc

avatar brianteeman brianteeman - alter_testresult - 26 Sep 2024 - brianteeman: Not tested
avatar brianteeman
brianteeman - comment - 26 Sep 2024

Removed my positive test as I think this is doing it the wrong way


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44136.

avatar RickR2H RickR2H - change - 27 Sep 2024
Labels Added: RTC bug
avatar RickR2H
RickR2H - comment - 27 Sep 2024

@brianteeman please test the new version.

avatar brianteeman brianteeman - test_item - 27 Sep 2024 - Tested successfully
avatar brianteeman
brianteeman - comment - 27 Sep 2024

I have tested this item ✅ successfully on a81d79c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44136.

avatar richard67
richard67 - comment - 28 Sep 2024

@RickR2H I've allowed myself to fix the merge conflict which was caused by your other, merged PR #44132 in file "modules/mod_articles/tmpl/default_items.php". What remains is the unresolved conversation above.

avatar richard67 richard67 - change - 28 Sep 2024
Status Ready to Commit Pending
avatar richard67
richard67 - comment - 28 Sep 2024

Back to pending as the test by @JeroenMoolenschot has been invalidated by a later change which was not just a branch update. I will restore @brianteeman 's test result as that was just invalidated by a branch update (with a merge conflict resolved by me but that is not relevant for the test result). But the inresolved conversation should be resolved, and it needs a 2nd human test.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44136.

avatar richard67 richard67 - alter_testresult - 28 Sep 2024 - brianteeman: Tested successfully
avatar brianteeman brianteeman - test_item - 28 Sep 2024 - Not tested
avatar brianteeman
brianteeman - comment - 28 Sep 2024

I have not tested this item.

Removing my test as the active makes no sense


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44136.

avatar Hackwar Hackwar - change - 28 Sep 2024
Labels Removed: RTC
avatar RickR2H
RickR2H - comment - 29 Sep 2024

@Quy could you please test again?

avatar Hackwar Hackwar - change - 29 Sep 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-09-29 09:16:19
Closed_By Hackwar
avatar Hackwar Hackwar - close - 29 Sep 2024
avatar Hackwar Hackwar - merge - 29 Sep 2024
avatar Hackwar
Hackwar - comment - 29 Sep 2024

I merged this because the latest changes were removing the unrelated active status and the actual code in this PR was successfully tested before. Thank you @RickR2H for your contribution.

Add a Comment

Login with GitHub to post a comment