Feeling Lucky
RTC
NPM Resource Changed
PR-5.2-dev
[#44129] - [5.2] Fix Dart Sass deprecations
- Fixed in Code Base
- 26 Oct 2024
- Medium
- Build: 5.2-dev
- # 44129
- Diff
- C-Lodder:sass-deprecations
User tests: Successful: Unsuccessful:
Summary of Changes
lighten() and darken() are global functions in Dart Sass, that were deprecated as of v1.79.0.
This PR replaces them with color.adjust() inside Joomla's SCSS
Note: Bootstrap's own SCSS still uses these functions, and may or may not fix said deprecations in v5, due to the fact they still support node-sass.
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.2-dev
|
||
viocassel
- comment
- 28 Sep 2024
I have tested this item ✅ successfully on e22174c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44129.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 28 Sep 2024
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44129.
| Labels |
Added:
RTC
|
||
pe7er
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-10-26 15:29:32 |
| Closed_By | ⇒ | pe7er |
I have tested this item ✅ successfully on e22174c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44129.