RTC bug Webservices PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar SniperSister
SniperSister
20 Sep 2024

Summary of Changes

This PR fixes the creation new menuitems if created via the webservices API. The bug fixed prevented API calls from setting component-specific parameters, as the component parameters were not joined in the form preprocessing.

Testing Instructions

  • Create a new menu item for the "feature articles" view of com_content via the webservices API. Set the num_columns parameter of the params array to 5.
  • Check the created item in the backend

Actual result BEFORE applying this Pull Request

  • "#Columns" field in the Blog Layout tab is empty

Expected result AFTER applying this Pull Request

  • "#Columns" field in the Blog Layout tab is set to 5

Example request payload

{
  "access": "1",
  "alias": "",
  "browserNav": "0",
  "component_id": "19",
  "home": "0",
  "language": "*",
  "link": "index.php?option=com_content&view=featured",
  "menutype": "mainmenu",
  "note": "",
  "params": {
    "cancel_redirect_menuitem": "",
    "catid": "",
    "custom_cancel_redirect": "0",
    "enable_category": "0",
    "menu-anchor_css": "",
    "menu-anchor_title": "",
    "menu-meta_description": "",
    "menu-meta_keywords": "",
    "menu_image": "",
    "menu_image_css": "",
    "menu_show": "1",
    "menu_text": "1",
    "page_heading": "",
    "page_title": "",
    "pageclass_sfx": "",
    "redirect_menuitem": "",
    "robots": "",
    "show_page_heading": "",
    "num_columns": 5
  },
  "parent_id": "1",
  "publish_down": "",
  "publish_up": "",
  "published": "1",
  "template_style_id": "0",
  "title": "MyPostTest",
  "toggle_modules_assigned": "1",
  "toggle_modules_published": "1",
  "type": "component"
}

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • [ x] No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • [ x] No documentation changes for manual.joomla.org needed

avatar SniperSister SniperSister - open - 20 Sep 2024
avatar SniperSister SniperSister - change - 20 Sep 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Sep 2024
Category Administration com_menus
avatar SniperSister SniperSister - change - 21 Sep 2024
Labels Added: bug PR-4.4-dev
avatar alikon alikon - test_item - 22 Sep 2024 - Tested successfully
avatar alikon
alikon - comment - 22 Sep 2024

I have tested this item ✅ successfully on 84ac7f8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44119.

avatar richard67 richard67 - test_item - 22 Sep 2024 - Tested successfully
avatar richard67
richard67 - comment - 22 Sep 2024

I have tested this item ✅ successfully on 84ac7f8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44119.

avatar richard67 richard67 - change - 22 Sep 2024
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 22 Sep 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44119.

avatar richard67 richard67 - change - 22 Sep 2024
Labels Added: RTC Webservices
avatar MacJoom MacJoom - change - 25 Sep 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-09-25 19:18:15
Closed_By MacJoom
avatar MacJoom MacJoom - close - 25 Sep 2024
avatar MacJoom MacJoom - merge - 25 Sep 2024
avatar MacJoom
MacJoom - comment - 25 Sep 2024

Thank you!

Add a Comment

Login with GitHub to post a comment