Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#44111] - [5.2] fix unescaped quotes in sampldata_blog language string

RTC Language Change PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar tecpromotion
tecpromotion
18 Sep 2024

Pull Request for Issue # .

Summary of Changes

add \

Testing Instructions

code review

Actual result BEFORE applying this Pull Request

class="d-grid gap-2 d-sm-block"

Expected result AFTER applying this Pull Request

class=\"d-grid gap-2 d-sm-block\"

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

b7740c4 18 Sep 2024 avatar tecpromotion fix
avatar tecpromotion tecpromotion - open - 18 Sep 2024
avatar tecpromotion tecpromotion - change - 18 Sep 2024
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Sep 2024
Category ⇒ Administration Language & Strings
avatar brianteeman
brianteeman - comment - 18 Sep 2024

are you sure it is necessary to escape the "

for example this is not escaped

joomla-cms/administrator/language/en-GB/plg_sampledata_blog.ini

Line 28 in 88fbc2c

PLG_SAMPLEDATA_BLOG_SAMPLEDATA_CONTENT_ARTICLE_4_INTROTEXT="<p>Your site has some commonly used modules already preconfigured. These include:</p><ul><li>Image (type: Custom), which holds the image beneath the menu. This is a Custom module that you can edit to change the image.</li><li>Popular Tags (type: Tags - Popular), which will appear if you use tagging on your articles. Enter a tag in the Tags field when editing.</li><li>Older Posts (type: Articles - Category), which lists out articles by categories.</li><li>Syndication (type: Syndication Feeds), which allows your readers to read your posts in a news reader.</li><li>Login Form (type: Login), which allows your users to access restricted areas of the website.</li></ul><p>Each of these modules has many options which you can experiment with in the Module Manager in your site Administrator. When you are logged in you can also select the edit icon in the top right corner which will take you to an edit screen for that module. Always be sure to save and close any module you edit.</p><p>Joomla! also includes many other modules you can incorporate in your site. As you develop your site you may want to add more modules that you can find at the <a href="https://extensions.joomla.org/">Joomla Extensions Directory.</a></p>"

or is this another bug to fix?

avatar tecpromotion
tecpromotion - comment - 18 Sep 2024

or is this another bug to fix?

I say it's a bug too and in my opinion rel and target should be added as well.

avatar tecpromotion tecpromotion - change - 18 Sep 2024
Labels Added: Language Change PR-5.2-dev
avatar sandewt sandewt - test_item - 18 Sep 2024 - Tested successfully
avatar sandewt
sandewt - comment - 18 Sep 2024

I have tested this item ✅ successfully on e7de066

code revieuw

EDIT

I see that you have added a second correction in the meantime. Is this one correct?
<a href=\"https://extensions.joomla.org/\" target=\"_blank\" rel=\"noopener noreferrer\">Joomla Extensions Directory.</a>

I would expect the following:
<a href=\"https:\/\/extensions.joomla.org/\" target=\"_blank\" rel=\"noopener noreferrer\">Joomla Extensions Directory.</a>

Actually this is another bug.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44111.
avatar Quy Quy - test_item - 18 Sep 2024 - Tested successfully
avatar Quy
Quy - comment - 18 Sep 2024

I have tested this item ✅ successfully on 70c049d

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44111.

avatar Quy Quy - alter_testresult - 18 Sep 2024 - sandewt: Tested successfully
avatar Quy Quy - change - 18 Sep 2024
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 18 Sep 2024

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44111.

avatar Hackwar Hackwar - change - 18 Sep 2024
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-09-18 21:41:46
Closed_By ⇒ Hackwar
Labels Added: RTC
avatar Hackwar Hackwar - close - 18 Sep 2024
avatar Hackwar Hackwar - merge - 18 Sep 2024
avatar Hackwar
Hackwar - comment - 18 Sep 2024

Thank you for your contribution @tecpromotion!

Add a Comment

Login with GitHub to post a comment