Language Change PR-5.2-dev Guided Tours Pending

User tests: Successful: Unsuccessful:

avatar obuisard
obuisard
17 Sep 2024

Summary of Changes

The 'Welcome' tour has unescaped quotes in a string.

Testing Instructions

Install a fresh instance of this PR.

Actual result BEFORE applying this Pull Request

The 'Welcome' tour runs properly.

Expected result AFTER applying this Pull Request

The 'Welcome' tour runs properly.
You should see:

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar obuisard obuisard - open - 17 Sep 2024
avatar obuisard obuisard - change - 17 Sep 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Sep 2024
Category Administration Language & Strings
avatar Kostelano
Kostelano - comment - 18 Sep 2024

If you got to the quotes, then there is an unescaped fragment fw-medium in the neighboring file.

<p>From <span class="fw-medium">Content -&gt; Site Modules</span> ...

https://github.com/joomla/joomla-cms/blob/4de70ecfea904e6bf3a69a5db8efd4208799b373/administrator/language/en-GB/guidedtours.joomla_whatsnew_5_2.ini#L1C1-L2C70

avatar tecpromotion
tecpromotion - comment - 18 Sep 2024

If you got to the quotes, then there is an unescaped fragment fw-medium in the neighboring file.

<p>From <span class="fw-medium">Content -&gt; Site Modules</span> ...

https://github.com/joomla/joomla-cms/blob/4de70ecfea904e6bf3a69a5db8efd4208799b373/administrator/language/en-GB/guidedtours.joomla_whatsnew_5_2.ini#L1C1-L2C70

I have created the PR #44110
Thank you.

avatar obuisard
obuisard - comment - 18 Sep 2024

Thanks Stefan @tecpromotion and Konstantin @Kostelano for the finding and correction!

avatar tecpromotion tecpromotion - test_item - 18 Sep 2024 - Tested successfully
avatar tecpromotion
tecpromotion - comment - 18 Sep 2024

I have tested this item ✅ successfully on 4839a83


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44106.

avatar Kostelano Kostelano - test_item - 18 Sep 2024 - Tested successfully
avatar Kostelano
Kostelano - comment - 18 Sep 2024

I have tested this item ✅ successfully on 4839a83


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44106.

avatar Hackwar Hackwar - change - 18 Sep 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-09-18 21:05:00
Closed_By Hackwar
Labels Added: Language Change PR-5.2-dev Guided Tours
avatar Hackwar Hackwar - close - 18 Sep 2024
avatar Hackwar Hackwar - merge - 18 Sep 2024
avatar Hackwar
Hackwar - comment - 18 Sep 2024

Thank you for your contribution @obuisard!

Add a Comment

Login with GitHub to post a comment