? Success

User tests: Successful: Unsuccessful:

avatar maxvalentini77
maxvalentini77
1 Oct 2014

Include "Fix reset password redirect" (Ref #3845) and resolve the issue "Password reset don't work. Joomla 3.3.5" (Ref #4403).

avatar maxvalentini77 maxvalentini77 - open - 1 Oct 2014
avatar jissues-bot jissues-bot - change - 1 Oct 2014
Labels Added: ?
avatar Kubik-Rubik
Kubik-Rubik - comment - 1 Oct 2014

Thank you for your fast reaction.

It is still not possible to logout on the profile edit page through the login module with this PR. You should add this task to the list of allowed tasks.

avatar sovainfo
sovainfo - comment - 1 Oct 2014

@test ok
Consider making logout possible a nice feature request for new PR.

avatar Kubik-Rubik
Kubik-Rubik - comment - 1 Oct 2014

@sovainfo For me the logout functionality is elementary in this constellation, this should be added in this PR before it is accepted. The users should always have the possibility to cancel the forced password change process.

avatar maxvalentini77
maxvalentini77 - comment - 1 Oct 2014

Thanks @Kubik-Rubik and @sovainfo for the feedback.
I'll look to add the logout to the list of allowed tasks.

avatar maxvalentini77
maxvalentini77 - comment - 1 Oct 2014

Added the logout to the list of allowed tasks.

avatar Kubik-Rubik Kubik-Rubik - test_item - 1 Oct 2014 - Tested successfully
avatar Kubik-Rubik
Kubik-Rubik - comment - 1 Oct 2014

@maxvalentini77

Thank you, now it works as expected. Thank you for providing this solution!

One more tester please!

avatar Kubik-Rubik Kubik-Rubik - change - 1 Oct 2014
Category Libraries
avatar sovainfo
sovainfo - comment - 1 Oct 2014

@test ok
It allows you to logout provided that option is available, tested with mod_login.

It allows you to cancel but tells you need to change password when you do, may that button should be a logout button instead.

avatar maxvalentini77
maxvalentini77 - comment - 1 Oct 2014

It allows you to cancel but tells you need to change password when you do, may that button should be a logout button instead.

Or remove them?
The cancel button in the site form and in the toolbar on administrator form are useless if you MUST change the password.

I think it is acceptable that the cancel button brings the user back to the page with a warning that he MUST change password.
(this is how it has worked so far)

avatar sovainfo
sovainfo - comment - 1 Oct 2014

Or make it work as a logout. Current behavior is rediculous. Don't provide buttons that don't get you anywhere.

avatar Kubik-Rubik
Kubik-Rubik - comment - 1 Oct 2014

This button has nothing to do with this PR and should be addressed in another PR. Please do not mess this PR up with changes not directly related to each other (here we have a change in the library, the button would be a change in the users component itself).

We need a second successful test to get this to RTC. Thank you!

avatar sovainfo
sovainfo - comment - 1 Oct 2014

As mentioned I am not the one that added the requirement of allowing logout, Already considered that out of scope!

Already provided the second ok for test!

avatar Kubik-Rubik
Kubik-Rubik - comment - 1 Oct 2014

@sovainfo Thank you!

We have 2 successful tests - RTC.

avatar Kubik-Rubik Kubik-Rubik - alter_testresult - 1 Oct 2014 - sovainfo: Tested successfully
avatar Kubik-Rubik Kubik-Rubik - change - 1 Oct 2014
Status Pending Ready to Commit
avatar phproberto phproberto - change - 8 Oct 2014
Labels Added: ?
avatar phproberto phproberto - close - 8 Oct 2014
avatar zero-24 zero-24 - close - 8 Oct 2014
avatar phproberto phproberto - change - 8 Oct 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-10-08 06:46:27
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment