[#44075] - [5.2] [Guided tours] Bug fixes for PR #43966
- Fixed in Code Base
- 18 Sep 2024
- Medium
- Build: 5.2-dev
- # 44075
- Diff
- tecpromotion:language-syntax-fix-guided-tours-whatsnewtour
User tests: Successful: Unsuccessful:
Pull Request for PR #43966
Summary of Changes
Add missing file header
Correction of the spelling of the language strings
add "noreferrer" to link
Testing Instructions
It should have no effect on the functionality.
Actual result BEFORE applying this Pull Request
language_string = ""
Expected result AFTER applying this Pull Request
language_string=""
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
Nested Subforms - Allows the nesting of Subform inside a Subform Custom Field. ==> Nested Subforms - Allows the nesting of a Subform inside a Subform Custom Field. or Nested Subforms - Allows the nesting of Subforms inside a Subform Custom Field.
I think its the first option assuming you can only nest one subform otherwise its the second
The PR #43204 allows the selection of subform fields in a subforms. There could be more than one. So that should be plural.
| Labels |
Added:
Language Change
PR-5.2-dev
Guided Tours
|
||
RTC
RTC
@tecpromotion ??? It doesn't have 2 successful human tests, or am I missing something? Approvals on GitHub just mean the PR is ok by review, but they are not equal to a test of the functionality by a human being.
Well I just see a review should be sufficient here. But still it needs "testers".
I have tested this item ✅ successfully on 4095578
With a good diff tool I was able to compare the details of the changes in the language string, which the diff on GitHub doesn't show.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44075.
I have tested this item ✅ successfully on 4095578
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44075.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44075.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-09-18 21:06:39 |
| Closed_By | ⇒ | Hackwar | |
| Labels |
Added:
RTC
|
||
Thanks for your contribution @obuisard and @brianteeman
Nested Subforms - Allows the nesting of Subform inside a Subform Custom Field.
==>
Nested Subforms - Allows the nesting of a Subform inside a Subform Custom Field.
or
Nested Subforms - Allows the nesting of Subforms inside a Subform Custom Field.
I think its the first option assuming you can only nest one subform otherwise its the second