[#44069] - [4.4] Fix start=0 in the pagination
- Fixed in Code Base
- 22 Sep 2024
- Medium
- Build: 4.4-dev
- # 44069
- Diff
- Fedik:fix-pagination-start0
User tests: Successful: Unsuccessful:
Pull Request for Issue #44049 .
Summary of Changes
Fix removing of start=0 from pagination for the first page.
Testing Instructions
Visit Category Blog or another list view with pagination.
Visit second page, and check the link for first page.
Actual result BEFORE applying this Pull Request
Link contain start=0
Expected result AFTER applying this Pull Request
Link without start=0
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
@Mich-es can you open https://issues.joomla.org/tracker/joomla-cms/44069 and click button "Tested successfully" so the test is counted.
I have tested this item ✅ successfully on 44c8277
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44069.
I have tested this item ✅ successfully on 44c8277
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44069.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
PR-4.4-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44069.
On some places, I get '0'
So, for me, instead of:
if ($limitstart !== null && $limitstart !== '') {
this works:
if ($limitstart !== null && $limitstart !== '' && $limitstart !== '0') {
It is expected, when limitstart have a value, then it will be added to URL.
The router code is skipping only empty values.
I have tested this item ✅ successfully on 44c8277
Tested successfully with $hideEmptyLimitstart set to true. Thank you.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44069.
| Labels |
Added:
RTC
|
||
| Title |
|
||||||
I have tested this item ✅ successfully on 62b3a63
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44069.
Just an idea, wouldn't be better to have $hideEmptyLimitstart true as default? I guess probably there are more components using pagination with hidden start=0 than those requireing this syntax...
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44069.
To get rid of all the pagination duplicates, it is necessary for @joomla to have the rel="canonical" attribute for this type of page, indicating as a canonical page the version of the page without the ?start parameter.
@Fedik is it possible to add this to the current Issue?
as far as I know, there will be a solution for other types of duplicate pages in Joomla in Joomla 5.2, but there is no solution for the ?start parameter, which can be solved by adding a canonical link and then Joomla will be completely protected from all types of duplicate pages.
is it possible to add this to the current Issue?
Nope, it's not as simple as it might seem.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-09-22 20:56:47 |
| Closed_By | ⇒ | MacJoom |
Thank you!
It works!