[#44061] - [4.4] Fix next exec calculation for task scheduler
- Fixed in Code Base
- 20 Sep 2024
- Medium
- Build: 4.4-dev
- # 44061
- Diff
- rdeutz:Task-next-exec-calculation
User tests: Successful: Unsuccessful:
Pull Request for Issue #42459 partly .
Summary of Changes
The calculation of the next execution is not working as expected. This fix is for the intervals:
- interval-minutes
- interval-hours
- interval-days
- interval-months
I haven't looked into the cron-execution but will do in the furture (seems to me working right).
Testing Instructions
Create a task (e.g. Sleep) and chose Interval Days and set "Interval in Days" to 1 and the "Execution Time (UTC)" to 11:11 and save it.
Actual result BEFORE applying this Pull Request
You will see that the day is the next day but the time is the current time.
Expected result AFTER applying this Pull Request
The day is the next day and the time is 11:11
Apply the patch and try again, now it should be as expected. Play around with the other options and settings.
For the calculation of the next execution I have used the current time, then I am adding the interval and finally set time and day if needed.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
| Labels |
Added:
PR-4.4-dev
|
||
I have tested this item ✅ successfully on 52f7cb7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44061.
@Quy I would set RTC because it is a good step in the right direction and we only have a few days before the last 4.4.x Version before securtiy only fixes will be released. It would be a shame to have it so broken as it is now. I am going to make a 2nd PR and will work on the other issues in the comment.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44061.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-09-20 07:26:40 |
| Closed_By | ⇒ | MacJoom | |
| Labels |
Added:
RTC
|
||
Thank you!
I have tested this item ✅ successfully on 52f7cb7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44061.