bug PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
11 Sep 2024

Summary of Changes

When creating a Smart Search menu item with a filter, the ID of the filter is displayed in the URL after the search has been submitted. This PR refactors the router to remove the unnecessary parameter.

Testing Instructions

  • Have something to search for in your Joomla installation, for example the testing sampledata.
  • Create a filter for Smart Search with some stuff selected.
  • Create a menu item for the Smart Search search view and select the filter in it.
  • Go to the menu item in the frontend and search for something random.

Actual result BEFORE applying this Pull Request

The URL contains a query element like &f=2.

Expected result AFTER applying this Pull Request

The URL does not contain the &f= query element.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 11 Sep 2024
avatar Hackwar Hackwar - change - 11 Sep 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Sep 2024
Category Front End com_finder
avatar fgsw fgsw - test_item - 12 Sep 2024 - Tested successfully
avatar fgsw
fgsw - comment - 12 Sep 2024

I have tested this item ✅ successfully on cf51a65


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44055.

avatar fgsw fgsw - test_item - 12 Sep 2024 - Not tested
avatar fgsw
fgsw - comment - 12 Sep 2024

I have not tested this item.

Saw to late the red marked information /Applications/MAMP/htdocs/components/com_finder/src/Service/Router.php on line 69 /index.php/en/search?f=1&q=joomla" method="get" role="search"> above the search module:
Untitled


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44055.
178d33d 12 Sep 2024 avatar Hackwar Fix
avatar Hackwar Hackwar - change - 12 Sep 2024
Labels Added: bug PR-5.2-dev
avatar fgsw
fgsw - comment - 13 Sep 2024

@Hackwar Same result /Applications/MAMP/htdocs/components/com_finder/src/Service/Router.php on line 69 /index.php/en/search?f=1&q=joomla" method="get" role="search">

avatar uglyeoin
uglyeoin - comment - 8 Oct 2024

@Hackwar I'm here if you need a test on any update.

Add a Comment

Login with GitHub to post a comment