[#44055] - [5.2] Finder Router: filter out unnecessary query elements
- Fixed in Code Base
- 18 Jan 2025
- Medium
- Build: 5.2-dev
- # 44055
- Diff
- Hackwar:5.2-finder-router
User tests: Successful: Unsuccessful:
Summary of Changes
When creating a Smart Search menu item with a filter, the ID of the filter is displayed in the URL after the search has been submitted. This PR refactors the router to remove the unnecessary parameter.
Testing Instructions
- Have something to search for in your Joomla installation, for example the testing sampledata.
- Create a filter for Smart Search with some stuff selected.
- Create a menu item for the Smart Search search view and select the filter in it.
- Go to the menu item in the frontend and search for something random.
Actual result BEFORE applying this Pull Request
The URL contains a query element like &f=2.
Expected result AFTER applying this Pull Request
The URL does not contain the &f= query element.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_finder |
I have not tested this item.
Saw to late the red marked information /Applications/MAMP/htdocs/components/com_finder/src/Service/Router.php on line 69 /index.php/en/search?f=1&q=joomla" method="get" role="search"> above the search module:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44055.
| Labels |
Added:
bug
PR-5.2-dev
|
||
I have tested this item ✅ successfully on 178d33d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44055.
@dautrich You didn't get information mentioned in #44055 (comment)?
I have tested this item ✅ successfully on 178d33d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44055.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44055.
I encountered the same issue as fgsw.
Tested with PHP 8.2, Joomla 5.2.2, after adding this PR, I get:
Warning: Undefined array key "f" in /usr/local/apache2/htdocs/components/com_finder/src/Service/Router.php on line 69
/index.php/search?f=2&q=templates" method="get" role="search">
I modified this. Can you please test again?
I have tested this item ✅ successfully on 6ba7068
Test using Patchtester on copy of real site.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44055.
I have tested this item ✅ successfully on 6ba7068
Test by using Prebuilt update package.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44055.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-01-18 10:36:46 |
| Closed_By | ⇒ | richard67 |
Thanks all.
I have tested this item ✅ successfully on cf51a65
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44055.