[#44050] - [4.4] Improve translation of aria label text by extra language keys
- Fixed in Code Base
- 11 Sep 2024
- Medium
- Build: 4.4-dev
- # 44050
- Diff
- chmst:a11y-pagination-aria-labels
User tests: Successful: Unsuccessful:
Pull Request for Issue #44040 .
Summary of Changes
Use different language Keys for Pagination Buttons. This enables better translation.
Testing Instructions
See #44040. For english sites, The Aria Labels in pagination are correct before and after patch.
Text can then be translated correcty.
For Example German "Gehe zur nächsten Seite" statt
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
"Zur Seite weiter wechseln" is not a correct german sentence.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Layout |
| Title |
|
||||||
I have tested this item ✅ successfully on ac0e2eb
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44050.
I have tested this item ✅ successfully on ac0e2eb
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44050.
| Labels |
Added:
Language Change
a11y
PR-4.4-dev
|
||
I have tested this item ✅ successfully on 9fa3463
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44050.
I have tested this item ✅ successfully on 9fa3463
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44050.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44050.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-09-11 05:57:12 |
| Closed_By | ⇒ | laoneo |
Thanks!
I am surprised at the way the current code creates the language strings. I can't see why it was created that way.
I am also surprised that no translation team has raised this issue before.
As the text in the core doesn't change and at least one language will be improved by this change then its all good by me