bug Small PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
8 Sep 2024

Summary of Changes

Fix duplicated DB queries for non-existing asset.

Testing Instructions

Enable debug and debug Query in the debug plugin.
Login in administrator section as manager.
Open Articles list table.
Check amount of DB queries in debug panel.

Or run folowing code, in templates/atum/index.php.

for ($i = 0; $i < 100; $i++) {
    $app->getIdentity()->authorise('core.edit', 'com_content.category.1');
}

Actual result BEFORE applying this Pull Request

Around 55.

With testing code it is around 155 or more;

Expected result AFTER applying this Pull Request

Around 45

With testing code it is around 45;

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 8 Sep 2024
avatar Fedik Fedik - change - 8 Sep 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Sep 2024
Category Libraries
avatar tkuschel
tkuschel - comment - 8 Sep 2024

You can also fix the strange comment "// Else we have to do an extra db query to fetch it from the table fetch it from table." with this PR.

avatar Fedik Fedik - change - 8 Sep 2024
Labels Added: bug Small PR-4.4-dev
avatar Fedik
Fedik - comment - 8 Sep 2024

done

avatar fgsw fgsw - test_item - 9 Sep 2024 - Tested successfully
avatar fgsw
fgsw - comment - 9 Sep 2024

I have tested this item ✅ successfully on 892c892

Without Pull Request: 74 Queries
With Pull Request: 47 Queries

Test installed Multilang (de, en, fa)- and Blog Sample Date (14 Articles).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44033.
avatar Hackwar Hackwar - test_item - 10 Sep 2024 - Tested successfully
avatar Hackwar
Hackwar - comment - 10 Sep 2024

I have tested this item ✅ successfully on 892c892


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44033.

avatar Hackwar Hackwar - change - 10 Sep 2024
Status Pending Ready to Commit
avatar Hackwar
Hackwar - comment - 10 Sep 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44033.

avatar laoneo laoneo - change - 10 Sep 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-09-10 14:37:07
Closed_By laoneo
avatar laoneo laoneo - close - 10 Sep 2024
avatar laoneo laoneo - merge - 10 Sep 2024
avatar laoneo
laoneo - comment - 10 Sep 2024

Thanks!

Add a Comment

Login with GitHub to post a comment