[#44029] - [4.4][inlinehelp] Add inlinehelp toggle button for custom fields
- Fixed in Code Base
- 9 Sep 2024
- Medium
- Build: 4.4-dev
- # 44029
- Diff
- conseilgouz:4.4-dev
User tests: Successful: Unsuccessful:
Summary of Changes
Add inlinehelp toggle button for custom fields
Testing Instructions
Edit a custom field and play with inlinehelp toggle button.
Actual result BEFORE applying this Pull Request
- no inlinehelp button
- description shown
Expected result AFTER applying this Pull Request
- Inlinehelp toggle button in toolbar next to help button.
- Descriptions hidden by default
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields Front End Plugins |
I made a mistake, it is not relevant
About Color field : it does not respect other fields definition : no directory params and I did not find yet where its value is defined.
| Labels |
Added:
PR-4.4-dev
|
||
I just created params/color.xml so inline help button is displayed for color custom field.
I have tested this item ✅ successfully on 43d1e6c
> I just created params/color.xml so inline help button is displayed for color custom field.
Yes, this solves the problem, the retest is successful.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44029.
@Kostelano : thank you
| Category | Administration com_fields Front End Plugins | ⇒ | Administration com_fields |
Instead of defining inlinehelp in every custom field plugin, it's done once in administrator/components/com_fields/forms/field.xml
This could also be done in administrator/components/com_fields/forms/group.xml after adding $toolbar->inlinehelp(); in administrator/components/com_fields/src/View/Group/HtmlView.php, but there is no description in any group.xml field, so Inline Help button will never be displayed.
I have tested this item ✅ successfully on 2a13f15
Everything works
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44029.
@conseilgouz can you ad [4.4] at begin of title? So user see what branch this pull request is without open it.
| Title |
|
||||||
| Title |
|
||||||
I have tested this item ✅ successfully on 2a13f15
Test:
- Content: Articles, Category
- Contacts: Contact, Mail, Category
- Users
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44029.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44029.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-09-09 14:31:45 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
RTC
|
||
Thanks!
I have tested this item ✅ successfully on b650613
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44029.