[#44008] - [5.3] Removing LegacyPropertyManagementTrait::setProperties() usage in Core
- Fixed in Code Base
- 4 Oct 2024
- Medium
- Build: 5.3-dev
- # 44008
- Diff
- Hackwar:5.2-legacyproperty-setproperties
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
The LegacyPropertyManagementTrait is deprecated and we are still using setProperties in some areas. This PR removes the usage of that method from all occurences in our core.
Testing Instructions
Test registering a user and logging in and view a category view in the frontend. That should trigger all the code. There should be no difference between before and after applying this PR.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration SQL com_admin Postgresql com_content com_media com_users Language & Strings Repository NPM Change JavaScript Front End com_contact com_newsfeeds com_tags Installation |
| Labels |
Added:
Language Change
NPM Resource Changed
PR-5.3-dev
|
||
| Category | Administration SQL com_admin Postgresql com_content com_media com_users Language & Strings Repository NPM Change JavaScript Front End com_contact com_newsfeeds com_tags Installation | ⇒ | Libraries |
Shouldn't the use LegacyPropertyManagementTrait; be removed in the files?
| Labels |
Removed:
Language Change
NPM Resource Changed
|
||
No, we can't remove those traits, because it would be a b/c break. I'm looking forward to removing the trait from everything in 6.0, but right now we are stuck with it.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-10-04 06:10:03 |
| Closed_By | ⇒ | laoneo |
Thanks!
Upmerge for 5.3 missing first?