Language Change bug PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar tecpromotion
tecpromotion
30 Aug 2024

Summary of Changes

I assume that the initial PR #43910 was against 5.1-dev @brianteeman?
In 5.2, two further strings are not sorted correctly.

Testing Instructions

code review

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar tecpromotion tecpromotion - open - 30 Aug 2024
avatar tecpromotion tecpromotion - change - 30 Aug 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Aug 2024
Category Administration Language & Strings
avatar brianteeman
brianteeman - comment - 30 Aug 2024

I am happy with this PR. The problem arises because some sorts put _ at the beginning and some put it at the end

avatar tecpromotion tecpromotion - change - 31 Aug 2024
Labels Added: Language Change PR-5.2-dev
avatar tecpromotion tecpromotion - change - 3 Sep 2024
Labels Added: bug
avatar Hackwar
Hackwar - comment - 11 Sep 2024

Merged after code review. Thank you @tecpromotion!

avatar Hackwar Hackwar - change - 11 Sep 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-09-11 16:42:19
Closed_By Hackwar
avatar Hackwar Hackwar - close - 11 Sep 2024
avatar Hackwar Hackwar - merge - 11 Sep 2024

Add a Comment

Login with GitHub to post a comment