[#43990] - [4.x] Fix default language value for taxonomy rows
- Fixed in Code Base
- 30 Aug 2024
- Medium
- Build: 4.4-dev
- # 43990
- Diff
- SniperSister:4.4-finder-taxonomy-language
User tests: Successful: 0 Unsuccessful: 0
Summary of Changes
So far com_finder taxonomy rows had an empty string as default parameter for the language column. Taxonomy rows with that empty string became unselectable one the multilanguage feature was enabled, as the language filter only filtered for the current language and the * character, see:
https://github.com/joomla/joomla-cms/blob/4.4-dev/administrator/components/com_finder/src/Service/HTML/Filter.php#L306
Testing Instructions
- Run the finder indexer, view the #__finder_taxonomy table and check the taxonomy column values.
- Apply the patch.
- Reindex
- Check the DB table again
Actual result BEFORE applying this Pull Request
Rows with empty string.
Expected result AFTER applying this Pull Request
Rows with empty strings are now using * as value
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Labels |
Added:
PR-4.4-dev
|
||
I have tested this item ✅ successfully on 0120dfd
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43990.
Hackwar
- 
@fgsw Thank you for screenshots for my better understanding :-)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43990.
I have tested this item ✅ successfully on 0120dfd
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43990.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43990.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-30 06:22:27 |
| Closed_By | ⇒ | laoneo |
I have tested this item ✅ successfully on c61e65b
Without Patch:
With Patch:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43990.