Pending

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
26 Aug 2024

Issue: The Maintenance: Clear Cache page does not display the correct number + size of cached files.

This PR corrects the Number of Files on the Maintenance: Clear Cache page.

Summary of Changes

When using Joomla's System - Page Cache plugin, an /administrator/cache/page folder with index.html file is created. When you visit one page on the front-end, you will cache one page.
However, the Maintenance: Clear Cache page shows 2 files under Number of Files because it also counts the index.html file (which is not a cached file). It's confusing to see that number.

Testing Instructions

  1. Switch on Joomla's System - Page Cache plugin

system-page-cache

  1. Goto the front-end and open one page. The Maintenance: Clear Cache counts 2 files.
  2. Open the website files, e.g. using an FTP client like FileZilla.
    You'll see just one cached file and the index.html.

files

Actual result BEFORE applying this Pull Request

You'll see too many cached files under Number of Files (and Size) because it includes the index.html:

maintenance-clear-cache

Expected result AFTER applying this Pull Request

You'll see the real number of cached files + size because the index.html is not counted as cache anymore:

after-pr

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar pe7er pe7er - open - 26 Aug 2024
avatar pe7er pe7er - change - 26 Aug 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2024
Category Libraries
avatar brianteeman
brianteeman - comment - 26 Aug 2024

This is not correct.

When you turn on the cache plugin a pages folder is not created.

When you visit a page on the site then the folder is created with an index.html and any other cache files

When you delete the cache using the system menu the entire cache folder is deleted. That includes the index.hmtl file. Therefore the number of cached files includes the index.html file

avatar HLeithner
HLeithner - comment - 15 Nov 2024

This pull request has been automatically rebased to 5.2-dev.

avatar HLeithner HLeithner - change - 15 Nov 2024
Title
[4.4] Cache: Fix for counting the Number of Files correctly
[5.2] Cache: Fix for counting the Number of Files correctly
avatar HLeithner HLeithner - edited - 15 Nov 2024

Add a Comment

Login with GitHub to post a comment