RTC Language Change PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
24 Aug 2024

Pull Request for Issue #43212 .
Replaces #43592

Summary of Changes

Several users mentioned confusion i the com_templates toolbar, caused by the delete-file and close-file button.
This is an attempt to provide a solution with as few changes as possible.
Some buttons are used in the whole system and cannot be changed for this view, so we have not many options for changes here.

Changes made here:

Button for Preview always at position 1, becaus it is always vivile also for non-super usres.

Change the text on the "close file" button to "close". Because this button does not only close the file but it closes the screen and redirects back, for users it does not matter if there is another action in the code.

Move the "Close" Button" directly after the action buttons, before the file management buttons.

Use the trash icon on the "file delete" button. We had many discussions about that - In Joomla the trash button means "trashed" => state = -2 not "deleted permanently", but when we think as a user not as a developer, the icon is completely clear here.

I improved the code a little bit by removing an unused variable and used switch instead of nested elseif.

Testing Instructions

Play around in templates and template styles, make child templates, manage files.
Whatever you want to do with your template should have a comprehensive and complete toolbar, in most cases the same as before.

Actual result BEFORE applying this Pull Request

see #43212.
delete button and close-file button.
grafik

Expected result AFTER applying this Pull Request

grafik

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar chmst chmst - open - 24 Aug 2024
avatar chmst chmst - change - 24 Aug 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2024
Category Administration com_templates Language & Strings
avatar chmst chmst - change - 24 Aug 2024
Title
Improve UX for template buttons - replace PR #43592
[5.2] Improve UX for template buttons - replace PR #43592
avatar chmst chmst - edited - 24 Aug 2024
avatar ChristineWk ChristineWk - test_item - 24 Aug 2024 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 24 Aug 2024

I have tested this item ✅ successfully on f45b391


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43975.

avatar exlemor exlemor - test_item - 24 Aug 2024 - Tested successfully
avatar exlemor
exlemor - comment - 24 Aug 2024

I have tested this item ✅ successfully on f45b391

I have tested this successfully. :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43975.

avatar Quy Quy - change - 24 Aug 2024
Status Pending Ready to Commit
Labels Added: Language Change PR-5.2-dev
avatar Quy
Quy - comment - 24 Aug 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43975.

avatar pe7er pe7er - change - 26 Aug 2024
Labels Added: RTC
avatar pe7er pe7er - change - 27 Aug 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-08-27 12:04:57
Closed_By pe7er
avatar pe7er pe7er - close - 27 Aug 2024
avatar pe7er pe7er - merge - 27 Aug 2024
avatar pe7er
pe7er - comment - 27 Aug 2024

Thanks @chmst !

Add a Comment

Login with GitHub to post a comment