[#43961] - [5.2] Remove trailing slash
- Fixed in Code Base
- 12 Sep 2024
- Medium
- Build: 5.2-dev
- # 43961
- Diff
- brianteeman:trailing_slash
User tests: Successful: Unsuccessful:
Pull Request for Issue #38856 .
Summary of Changes
renderelement adds a trailing slash when adding css links
link is a void element and the trailing slash should not be used in html5 (it was only needed for xhtml
Testing Instructions
View the source of the webpage OR use https://validator.w3.org/
Note with chrome inspect is not the same as view source
Actual result BEFORE applying this Pull Request
all css links in the head of the page have a trailing slash
Expected result AFTER applying this Pull Request
no trailing slash
additional information
https://github.com/validator/validator/wiki/Markup-%C2%BB-Void-elements#trailing-slashes-in-void-element-start-tags-do-not-mark-the-start-tags-as-self-closing
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item ✅ successfully on 97f95b3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43961.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.2-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43961.
| Labels |
Added:
RTC
|
||
I have tested this item ✅ successfully on b77c3ae
I have successfully tested this.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43961.
I have tested this item ✅ successfully on b77c3ae
Removes all the trailing cross-throughs in the
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43961.
| Labels |
Added:
bug
|
||
Thank you for your contribution @brianteeman!
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-09-12 07:30:21 |
| Closed_By | ⇒ | Hackwar |
Thanks
I have tested this item ✅ successfully on 97f95b3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43961.