Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#4396] - Clearfix cleanup

?

User tests: Successful: Unsuccessful:

avatar nternetinspired
nternetinspired
30 Sep 2014

Removes a superflous clearing div, in line with other instances in this file; lines 71-73

avatar nternetinspired nternetinspired - open - 30 Sep 2014
avatar jissues-bot jissues-bot - change - 30 Sep 2014
Labels Added: ?
avatar zero-24
zero-24 - comment - 30 Sep 2014

@nternetinspired any testing needed?

avatar nternetinspired
nternetinspired - comment - 30 Sep 2014

There's should be no observable change after this change.

avatar brianteeman brianteeman - change - 30 Sep 2014
Category ⇒ Code style Templates (site)
avatar nicksavov nicksavov - change - 16 Oct 2014
Labels Added: ?
avatar suredweb suredweb - test_item - 17 Oct 2014 - Tested successfully
avatar truptitasol truptitasol - test_item - 17 Oct 2014 - Tested successfully
avatar gunjanpatel gunjanpatel - change - 17 Oct 2014
Status Pending ⇒ Ready to Commit
avatar gunjanpatel
gunjanpatel - comment - 17 Oct 2014

Moving to RTC as we have two successful tests.

avatar Bakual
Bakual - comment - 17 Oct 2014

Removing this clearfix will break the print view in the cases. See
before:
image
after:
image

That is using a default installation with testing sample data and Protostar.

Closing as it would change appearance and potentially breaks templates.

avatar Bakual Bakual - close - 17 Oct 2014
avatar Bakual Bakual - change - 17 Oct 2014
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-10-17 12:13:51

Add a Comment

Login with GitHub to post a comment