PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
18 Aug 2024

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the list of files to be deleted on update in file administrator/components/com_admin/script.php in the 5.1-dev branch in preparation for the next 5.1.3 release.

All files added by this PR are deleted due to the update the joomla framework composer dependencies, where developer-only files are not shipped anymore.

Code review, or if you want to do a real test:

Update a 5.1.2 to a current 5.1-dev build which contains the changes from the merged PR #43943 to get the actual result, and update a 5.1.2 to the patched package created by Drone for this PR to get the expected result.

To create a current 5.1-dev build, open a Linux or WSL shell, change to the base folder of your git clone, checkout the 5.1-dev branch of the CMS repo or update your 5.1-dev branch to that (upstream) and then run:

php ./build/build.php --remote=HEAD --exclude-gzip --exclude-zstd

And here you can find the patched update package or custom update URL created by Drone for this PR: https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/43944/downloads/78199/Joomla_5.1.3-rc2-dev+pr.43944-Development-Update_Package.zip

Actual result BEFORE applying this Pull Request

The files added by this PR to file administrator/components/com_admin/script.php are still present after the update.

Expected result AFTER applying this Pull Request

The files added by this PR to file administrator/components/com_admin/script.php have been removed with the update.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 18 Aug 2024
Category Administration com_admin
avatar richard67 richard67 - open - 18 Aug 2024
avatar richard67 richard67 - change - 18 Aug 2024
Status New Pending
avatar richard67 richard67 - change - 18 Aug 2024
The description was changed
avatar richard67 richard67 - edited - 18 Aug 2024
avatar bembelimen bembelimen - change - 18 Aug 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-08-18 12:10:44
Closed_By bembelimen
Labels Added: PR-5.1-dev
avatar bembelimen bembelimen - close - 18 Aug 2024
avatar bembelimen bembelimen - merge - 18 Aug 2024
avatar bembelimen
bembelimen - comment - 18 Aug 2024

Thx

Add a Comment

Login with GitHub to post a comment