RTC bug PR-5.1-dev PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
17 Aug 2024

Pull Request for Issue # .

Summary of Changes

This is fix for extensions which triggers onUserAfterLogin, onUserAfterLogout, onUserLoginFailure, onUserLogoutFailure events in their code.
Prior Joomla 5 these events had 1 argument, with Joomla 5 they have 2 arguments, to be consisten with onUserLoginEvent and onUserLogiutEvent events.

Testing Instructions

Add following code, in to index.php of the template:

$e1 = new \Joomla\CMS\Event\User\AfterLoginEvent('onFooBar', [['option' => 1]]);
$e2 = new \Joomla\CMS\Event\User\LoginFailureEvent('onFooBar', [['user' => 1]]);
$e3 = new \Joomla\CMS\Event\User\LogoutFailureEvent('onFooBar', [['user' => 1]]);
dd($e1, $e2, $e3);

Actual result BEFORE applying this Pull Request

An error page.

Expected result AFTER applying this Pull Request

Dump of event objects, on blank page.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2024
Category Libraries
avatar Fedik Fedik - open - 17 Aug 2024
avatar Fedik Fedik - change - 17 Aug 2024
Status New Pending
avatar Fedik Fedik - change - 17 Aug 2024
Labels Added: bug PR-5.1-dev
avatar fgsw fgsw - test_item - 17 Aug 2024 - Tested successfully
avatar fgsw
fgsw - comment - 17 Aug 2024

I have tested this item ✅ successfully on 0cfd120


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43934.

avatar viocassel viocassel - test_item - 17 Aug 2024 - Tested successfully
avatar viocassel
viocassel - comment - 17 Aug 2024

I have tested this item ✅ successfully on 0cfd120


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43934.

avatar Quy Quy - change - 17 Aug 2024
Status Pending Ready to Commit
avatar Quy
Quy - comment - 17 Aug 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43934.

avatar Hackwar Hackwar - change - 28 Aug 2024
Title
[5.1] Fix of backward compatibility for Login event arguments
[5.2] Fix of backward compatibility for Login event arguments
avatar Hackwar Hackwar - edited - 28 Aug 2024
avatar Hackwar Hackwar - change - 11 Sep 2024
Labels Added: RTC PR-5.2-dev
avatar Hackwar
Hackwar - comment - 11 Sep 2024

Thank you for your contribution @Fedik!

avatar Hackwar Hackwar - close - 11 Sep 2024
avatar Hackwar Hackwar - merge - 11 Sep 2024
avatar Hackwar Hackwar - change - 11 Sep 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-09-11 22:12:29
Closed_By Hackwar

Add a Comment

Login with GitHub to post a comment