This PR works BUT maybe there are other consequences of this changes as it was introduced by @Hackwar with #39114

In the tag model, the $item attribute wasn't defined. $tag at the same time wasn't used. With $item being initialised as an array, we can remove a bunch of checks. At the same time we can now properly throw a 404 if the number of tag IDs doesn't match the number of tags found in the database matching these IDs. (we might want to rewrite the TagModel::getItem() method to use a single query instead of loading each tag separately with a Table call...)

I have tested this item ✅ successfully on 798cbde

Tested with Joomla 4.4.7 PHP 8.1

I have tested this item ✅ successfully on 798cbde

Does exactly as it should displaying only the public tag if not logged in and both if logged in

I have tested this item ✅ successfully on 798cbde

Tested with J4.4.7 and PHP 8.3.6

@softforge was faster than I was!

RTC

As @brianteeman already stated: I'm not sure that this is correct. The behavior of tags was never defined and is a big mess of different and competing concepts. Should it display all items which only match one tag or all tags? If a tag is not available to the current user, should the view display all items which match the other tag or would we still expect a filtered list with less items?

ok tags are a big mess, we can all agree

this pr fix a "common sense" behavior
not more not less

This really needs to be fixed, so I merged it. Thanks for the contribution.