?

Success

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
29 Sep 2014

This pull request fixes the Fatal error issue which is reported at https://groups.google.com/forum/#!topic/joomla-dev-general/vNaXN3RGmb8

The reason of the error is because the link has table variable in query string and after the command in line 652 parse_str(parse_url($table->link, PHP_URL_QUERY)); , the table object (which is a local variable in the method) is replaced by the value of table variable in the link (which is an integer value in the sample link) and causes the fatal error when the method $table->getProperties(1); is called (because $table is not an object anymore).

How to test :

  1. Create an menu item, type external url, type the sample link http://sbkost.sm-u.de/index.php?seite=spielplan&table=993 (or any url which has table variable in query string)

  2. Save it and you will see the fatal error

  3. Apply this patch

  4. Check it again and make sure the URL is saved.

I also made some small changes the code of getItem method:

  1. Remove the line of code parse_str(parse_url($table->link, PHP_URL_QUERY), $args); because it is written in switch block already.

  2. Remove the command $app = JFactory::getApplication(); because the $app variable is not used in that method at all.

Votes

# of Users Experiencing Issue
0/1
Average Importance Score
3.00

avatar joomdonation joomdonation - open - 29 Sep 2014
avatar jissues-bot jissues-bot - change - 29 Sep 2014
Labels Added: ?
avatar JoomliC
JoomliC - comment - 30 Sep 2014

@test success

Works as expected!

avatar joomdonation
joomdonation - comment - 30 Sep 2014

Thanks @JoomliC for testing (my first pull request :) ).

avatar brianteeman brianteeman - change - 1 Oct 2014
Category SEF
avatar JoomliC
JoomliC - comment - 1 Oct 2014

@joomdonation You're welcome! ;-)

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar JoomliC JoomliC - test_item - 1 Oct 2014 - Tested successfully
avatar byallanhansen
byallanhansen - comment - 1 Oct 2014

Test ok.

avatar joomdonation
joomdonation - comment - 1 Oct 2014

Thanks Allan for testing :).

avatar roland-d roland-d - alter_testresult - 1 Oct 2014 - byallanhansen: Tested successfully
avatar roland-d roland-d - change - 1 Oct 2014
Status Pending Ready to Commit
avatar phproberto phproberto - change - 8 Oct 2014
Labels Added: ?
avatar phproberto phproberto - close - 8 Oct 2014
avatar phproberto phproberto - change - 8 Oct 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-10-08 06:51:57

Add a Comment

Login with GitHub to post a comment