[#43918] - Revert "[5.2] Remove legacy code for filtering state in backend model…
- Closed
- 16 Aug 2024
- Medium
- Build: 5.2-dev
- # 43918
- Diff
- brianteeman:revert
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
This reverts (#43230)
Clearly the code is used and cannot simply be removed as was done in the original pr
Testing Instructions
This is for 5.2 only
Clear all session storage, cookies etc
Log in to the admin and go to the system page
Actual result BEFORE applying this Pull Request
Language Overrides - error undefined constant
Update Sites - no results
Expected result AFTER applying this Pull Request
All works as expected
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_associations com_cache com_content com_finder com_installer com_languages com_menus com_modules com_templates com_users |
| Status | New | ⇒ | Pending |
Sorry I don't remember how to validate my check
@fontanil You go to the PR in the issue tracker here https://issues.joomla.org/tracker/joomla-cms/43918 , then use the blue "Test this" button at the top left corner, select your test result and submit.
I have tested this item ✅ successfully on a69c80e
Tested successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43918.
I am aware of the problem in the overrides and will fix that. Reverting the whole PR is wrong and will not happen.
it is not just the language overrides
I made the PR as a temp measure until someone had the time and was able to investigate the issue with all the components and still allow people to test 5.2
I have tested this item ✅ successfully on a69c80e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43918.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-16 12:41:19 |
| Closed_By | ⇒ | Hackwar | |
| Labels |
Added:
PR-5.2-dev
|
||
thanks
Thanks!
Thanks @brianteeman
Tested with Patch tester, the PR works fine for me: Update Sites and Langage Overrides
Sorry I don't remember how to validate my check
Robert