Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#43878] - [5.1] Fix header translation for modal select field

RTC bug PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
3 Aug 2024

Pull Request for Issue #42918

Summary of Changes

Fix header translation for modal select field

Testing Instructions

Add following field XML, somewhere, example in Custom HTML module.

<field
  type="ModalSelect"
  name="article"
  label="Article"

  select="true"
  titleSelect="JGLOBAL_SELECT_AN_OPTION"
  urlSelect="index.php?option=com_content&amp;view=articles&amp;layout=modal&amp;tmpl=component"
  clear="true"
/>

Then edit the form with it, click "select" button.
Check the dialog heading.

Actual result BEFORE applying this Pull Request

The heading is untranslated language constant.

Expected result AFTER applying this Pull Request

The heading is translated

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 3 Aug 2024
avatar Fedik Fedik - change - 3 Aug 2024
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Aug 2024
Category ⇒ Layout
avatar Quy Quy - test_item - 7 Aug 2024 - Tested successfully
avatar Quy
Quy - comment - 7 Aug 2024

I have tested this item ✅ successfully on 1ddceaf

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43878.

avatar fgsw fgsw - test_item - 7 Aug 2024 - Tested successfully
avatar fgsw
fgsw - comment - 7 Aug 2024

I have tested this item ✅ successfully on 1ddceaf

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43878.

avatar Quy Quy - change - 7 Aug 2024
Status Pending ⇒ Ready to Commit
Labels Added: bug PR-5.1-dev
avatar Quy
Quy - comment - 7 Aug 2024

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43878.

avatar Quy Quy - change - 7 Aug 2024
Labels Added: RTC
avatar bembelimen bembelimen - change - 10 Aug 2024
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-08-10 09:40:47
Closed_By ⇒ bembelimen
avatar bembelimen bembelimen - close - 10 Aug 2024
avatar bembelimen bembelimen - merge - 10 Aug 2024
avatar bembelimen
bembelimen - comment - 10 Aug 2024

Thx

Add a Comment

Login with GitHub to post a comment