Feeling Lucky
NPM Resource Changed
PR-5.2-dev
[#43869] - [5.2] Set a fix width for icons on the main menu
- Closed
- 1 Aug 2024
- Medium
- Build: 5.2-dev
- # 43869
- Diff
- HLeithner:5.2/fix/atum-sidebar-icon
- Pending continuous-integration/drone/push Build is running Details
- Failure continuous-integration/appveyor/branch AppVeyor build failed Details
- Success Download Prebuilt packages are available for download. Details
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Set the width of the main menu icon in backend template to 1rem
Testing Instructions
Install patched version.
Create a custom backend menu with different sized frontawesome icons
check the menü
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-01 09:35:13 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
NPM Resource Changed
PR-5.2-dev
|
||
Closing this since it's the wrong approach, we should add the class "fa-fw" to the icons. thx @bembelimen