[#43862] - [5.2] Multilang: Remove restrictions for home language menu items
- Fixed in Code Base
- 18 Aug 2024
- Medium
- Build: 5.2-dev
- # 43862
- Diff
- Hackwar:5.2-langhomemenuitem
User tests: Successful: Unsuccessful:
Summary of Changes
The multilanguage system currently requires each home menu item to be in a separate menu, making the setup unnecessarily complex. There is no reason for forcing this behavior and this PR removes that. With this PR, the restriction is removed and you can put all home menu items into one menu. In the backend menu, the menu listing is changed to display the home icon for menus with more than one home menu item.
Testing Instructions
Setup a multi language website and try to save all home language menu items in one menu.
Actual result BEFORE applying this Pull Request
Error when saving.
Expected result AFTER applying this Pull Request
No errors.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus Libraries |
Tested Successfully but 2 things to consider:
- Should there be another Sample Data Mode for the menus?
- When I filter the menu items by language the nesting is not displayed correctly, should there be another filter ?
When I filter the menu items by language the nesting is not displayed correctly, should there be another filter ?
Can you post a screenshot as it looks ok to me
It looks like this after filtering altough its nested:
Unable to replicate (or i dont understand)
indeed - yours is still nested -mine not
indeed - yours is still nested -mine not
please post the full screenshot
Sorry was my mistake, the nested Item was set to "all"
I am still confused that all is not really "All" but just "All" - I mean if something is set to all it should apply for every other language too.
I have tested this item ✅ successfully on bc7029b
Works as expected.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43862.
I have made a pr to your branch for the multilangstatus issue mentioned above
| Labels |
Added:
PR-5.2-dev
|
||
| Category | Administration com_menus Libraries | ⇒ | Administration com_languages com_menus Language & Strings Libraries |
I have tested this item ✅ successfully on 1fd1d4e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43862.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43862.
| Labels |
Added:
RTC
Language Change
|
||
We had an issue with PostgreSQL in the admin menu, but thanks to @muhme this is now fixed. @brianteeman @coolcat-creations would you be able to test this again? Basically it would be enough to make sure that the backend menu still functions as expected.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43862.
I have tested this item ✅ successfully on 7d82dcd
still ok
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43862.
| Labels |
Removed:
RTC
|
||
On a nightly build:
- Installation Multilingual Sample Data (en-GB, de-DE)
- Installation Testing Sample Data
- Move all Menu items of both languages to "Main Menu"
See Icon "Home Default" (white House) in "Main Menu Testing" and "Main Menu":
Test System Information:
PHP Built On Darwin Air.local 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:13:00 PDT 2024; root:xnu-10063.141.2~1/RELEASE_X86_64 x86_64
Database Type mysql
Database Version 8.0.35
Database Collation utf8mb4_unicode_ci
Database Connection Collation utf8mb4_0900_ai_ci
Database Connection Encryption None
Database Server Supports Connection Encryption Yes
PHP Version 8.3.8
Web Server Apache/2.4.58 (Unix) OpenSSL/1.1.1u mod_fastcgi/mod_fastcgi-SNAP-0910052141
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 5.2.0-alpha4-dev Development [ Uthabiti ] 23-July-2024 16:01 GMT
Joomla Backward Compatibility Plugin Disabled
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:129.0) Gecko/20100101 Firefox/129.0
@fgsw That is the expected behavior. If a menu contains more than one home menu item, it should show the house icon next to it. We can't really display the different flags, since that would already get ugly with 2 flags.
If you could mark this as tested successfully, then I would try to still get this into beta 1.
I have tested this item ✅ successfully on ea5b52c
@Hackwar Thanks for comment. I thought the icon is only for home-menu-item-all languages.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43862.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43862.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-18 09:15:09 |
| Closed_By | ⇒ | bembelimen |
Thx
Awesome work Super Joomlers! Thanks for this feature
I created a multilingual site with 4 languages and the multilingual sample data.
I moved all the menu items to one menu and deleted the other menus
That all worked as expected.
It just left the check in the status module to be updated as the information is no longer correct