[#43858] - [5.3] Languagefilter: Refactoring of routing
- Pending
- Medium
- Build: 5.2-dev
- # 43858
- Diff
- Hackwar:5.2-routing-languagefilter
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for issue #24315, #25449, #39181
Summary of Changes
This is a refactoring of the routing component of the languagefilter plugin. The goal are as follows:
- Allow to parse URLs more than once. Right now the parseing of the languagefilter plugin sets a lot of state and even does redirects.
- When the prefix of the default language is set to be removed, the redirect for the language switch is removed.
- Make the code simpler and more reliable.
Right now this PR is a Proof Of Concept and is NOT ready. This is to collect feedback from the community and other developers.
Testing Instructions
Setup different multilanguage sites and apply the patch. The default behavior should not change, except that when the default prefix is removed, you can switch the language without an additional redirect.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
PR-5.2-dev
|
||
| Labels |
Added:
Feature
|
||
@Slava287 Please go to the issue tracker here https://issues.joomla.org/tracker/joomla-cms/43858 and mark your test result by using the blue "Test this" button at the top left corner, selecting your test result and finally submit, so that your test is properly counted. Just a comment here is not enough. Thanks in advance.
I have tested this item ✅ successfully on 3f9a0c5
Everything works correctly. There are no errors. I also tested it on the latest version of Joomla! 5.1.3 Stable
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43858.
Ok
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43858.
When suffix are enabled, this unfortunately right now creates URLs like /en.html. I still have to take a look what we have to do here.
Hello. Indeed, I didn’t notice it right away
| Title |
|
||||||
| Labels |
Added:
PR-5.3-dev
Removed: PR-5.2-dev |
||
Now the URLs should all be generated correctly.
Works. Thank you!