[#43857] - [5.3] Form control fields, new API
- Fixed in Code Base
- 16 Oct 2024
- Medium
- Build: 5.2-dev
- # 43857
- Diff
- Fedik:form-control-fields
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Replace control inputs hardcoded into the form layout with an API which allows to add this fields programaticaly.
Before PR (the form layout):
<input type="hidden" name="task" value="">
<input type="hidden" name="return" value="<?php echo $input->getBase64('return'); ?>">
<input type="hidden" name="forcedLanguage" value="<?php echo $input->get('forcedLanguage', '', 'cmd'); ?>">
<?php echo HTMLHelper::_('form.token'); ?>After PR:
// In Controller/View
$this->form
->addControlField('task', '')
->addControlField('return', $input->getBase64('return', ''))
->addControlField('forcedLanguage', $forcedLanguage);
// In the form layout
echo $this->form->renderControlFields();For now I have updated following forms:
- Article
- Category
- Menu
Will update more, when there will be a positive feedbacks.
Testing Instructions
Code review.
Create/edit Article, Category, Menu item. All should work as before.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org: joomla/Manual#322
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_content com_menus Front End Libraries |
| Title |
|
||||||
PS. testet on
Wampserver install version 3.3.2 installed on 2024-04-03
Updated to 3.3.6 on 2024-08-04
MySQL 8.2.0 Port 3306
Apache 2.4.62
PHP 8.3.10
error_reporting = E_ALL
Display Errors = on
With
2024-08-09
5.2 dev
a9980fe
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43857.
version a9980fe
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43857.
It's weird that my text disappears or gets changed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43857.
| Labels |
Added:
Feature
PR-5.2-dev
|
||
I have tested this item ✅ successfully on c24da87
Tested successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43857.
I have tested this item ✅ successfully on c24da87
I was able to test successfully :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43857.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43857.
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-10-16 18:30:42 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
RTC
PR-5.3-dev
Removed: PR-5.2-dev |
||
thanks, first step for form renderer
I have tested this item ✅ successfully on 5cfe985
A long life in IT, I have learned that everything changes.
A wise controller, from Italy, whom I once met, said that we should remember that we did not invent solutions to problems that we did not have! Extra testing, modifying working code, and so on.
The code does as described, it is as such ok.
I miss a use case for this change. What is it that is being tried to solve?
It could just be that I just haven't seen it.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43857.