[#43854] - [5.2] [Guided tours] dark mode colors do not contrast well against the overall interface
- Fixed in Code Base
- 8 Aug 2024
- Medium
- Build: 5.2-dev
- # 43854
- Diff
- obuisard:guided-tours-darkmode
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Guided tours popups do not have a good contrast against the Joomla backend.
It is very difficult to distinguish the tour popups from the rest and even know what the step targets are.
This PR proposes to improve the contrast and change the popup colors for dark mode.
We are keeping visual cues from the light version (darker header color than the popup content).
The header color is the same color as the editor header, so that we keep colors similar in the template.
Testing Instructions
Run any tour once in light and once in dark mode.
You can try and test in conjunction with PR#43825 (to fix the arrows).
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.2-dev
|
||
I have tested this item ✅ successfully on 1d3a1ee
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43854.
I have tested this item ✅ successfully on 1d3a1ee
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43854.
OT: When checking in dark mode, I see this:
Hackwar
- | Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-08 18:50:23 |
| Closed_By | ⇒ | pe7er |
Thank you!
I didn't find any issue with the existing colours but if others do then this PR works as described
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43854.