[#43819] - [5.2] Adding phpstan to drone setup
- Closed
- 15 Aug 2024
- Medium
- Build: 5.2-dev
- # 43819
- Diff
- Hackwar:5.2-phpstan2
User tests: Successful: Unsuccessful:
Summary of Changes
This PR adds the phpstan static code analyser to our composer dependencies and to our drone setup. It is configured to ignore a series of false positives and to list all deprecations as well. Its configuration file is excluded from the build script. For now phpstan is only set to scan in level 0. When all reports from that are fixed, we can raise that level gradually. Since phpstan will throw failures for a long time, failures are set to be ignored in drone.
phpstan also allows to register a baseline of errors right now and then throw errors when the result differs from that baseline, but that is something for the future.
Testing Instructions
See phpstan step in drone and its results.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository External Library Composer Change |
| Labels |
Added:
Unit/System Tests
Composer Dependency Changed
PR-5.2-dev
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-15 08:36:05 |
| Closed_By | ⇒ | Hackwar |
To get the fully power of PHPStan, you should add a minimal bootstrap file to discover more symbols as I did in DPDocker here.