[#43801] - [5.1] Update bump script also to update package-lock.json
- Fixed in Code Base
- 18 Jul 2024
- Medium
- Build: 5.1-dev
- # 43801
- Diff
- HLeithner:5.1/fix/bump-script
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #43743 .
Summary of Changes
Also update the package-lock.json on version bump
Testing Instructions
php build/bump.php -v 5.2.3
Actual result BEFORE applying this Pull Request
package.json is updated
package-lock.json is not updated
Expected result AFTER applying this Pull Request
package.json is updated
package-lock.json is updated
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository |
I have tested this item ✅ successfully on eba833d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43801.
I have tested this item ✅ successfully on eba833d
by code review
Thanks!!!!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43801.
(I got a php fatal error on line 313 BUT i ran it on windows and I seem to recall the script will not run on windows and that part of the file is not part of this PR and the parts in this PR all completed correctly)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43801.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.1-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43801.
I tested it and it worked on linux, also line 313 is only a preg_replace so shouldn't fail
| Labels |
Added:
RTC
|
||
Thank you @brianteeman and @richard67 for testing!
Thanks @dgrammatiko
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-07-18 10:05:59 |
| Closed_By | ⇒ | LadySolveig |
Thanks @HLeithner